Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

edit predictions: Iterate on onboarding modal copywriting (#24779)

Browse source 
Release Notes:

- N/A

---------

Co-authored-by: Nathan Sobo <1789+nathansobo@users.noreply.github.com>
This commit is contained in:
Danilo Leal 2025-02-12 23:07:20 -03:00 • committed by GitHub
parent f0cd71e43c
commit 3d68dba696
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
assets/icons/zed_predict_bg.svg
View file

@ -1,4 +1,4 @@
<svg width="480" height="128" xmlns="http://www.w3.org/2000/svg"> <svg width="550" height="128" xmlns="http://www.w3.org/2000/svg">
<defs> <defs>
<pattern id="tilePattern" width="23" height="23" patternUnits="userSpaceOnUse"> <pattern id="tilePattern" width="23" height="23" patternUnits="userSpaceOnUse">
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">

Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 971 B

After

Width:  |  Height:  |  Size: 971 B

Before After
Before After

20
crates/zeta/src/onboarding_modal.rs
View file

@ -168,7 +168,7 @@ impl Render for ZedPredictModal {
.id("edit-prediction-onboarding") .id("edit-prediction-onboarding")
.key_context("ZedPredictModal") .key_context("ZedPredictModal")
.relative() .relative()
.w(px(480.)) .w(px(550.))
.h_full() .h_full()
.max_h(max_height) .max_h(max_height)
.p_4() .p_4()
@ -201,7 +201,7 @@ impl Render for ZedPredictModal {
svg() svg()
.path("icons/zed_predict_bg.svg") .path("icons/zed_predict_bg.svg")
.text_color(cx.theme().colors().icon_disabled) .text_color(cx.theme().colors().icon_disabled)
.w(px(460.)) .w(px(530.))
.h(px(128.)) .h(px(128.))
.overflow_hidden(), .overflow_hidden(),
), ),
@ -285,7 +285,9 @@ impl Render for ZedPredictModal {
if self.user_store.read(cx).current_user().is_some() { if self.user_store.read(cx).current_user().is_some() {
let copy = match self.sign_in_status { let copy = match self.sign_in_status {
SignInStatus::Idle => "Get accurate and instant edit predictions at every keystroke. Before setting Zed as your edit prediction provider:", SignInStatus::Idle => {
"Zed can now predict your next edit on every keystroke. Powered by Zeta, our open-source, open-dataset language model."
}
SignInStatus::SignedIn => "Almost there! Ensure you:", SignInStatus::SignedIn => "Almost there! Ensure you:",
SignInStatus::Waiting => unreachable!(), SignInStatus::Waiting => unreachable!(),
}; };
@ -327,7 +329,7 @@ impl Render for ZedPredictModal {
.child( .child(
Checkbox::new("tos-checkbox", self.terms_of_service.into()) Checkbox::new("tos-checkbox", self.terms_of_service.into())
.fill() .fill()
.label("Read and accept the") .label("I have read and accept the")
.on_click(cx.listener(move |this, state, _window, cx| { .on_click(cx.listener(move |this, state, _window, cx| {
this.terms_of_service = *state == ToggleState::Selected; this.terms_of_service = *state == ToggleState::Selected;
cx.notify(); cx.notify();
@ -351,7 +353,7 @@ impl Render for ZedPredictModal {
"training-data-checkbox", "training-data-checkbox",
self.data_collection_opted_in.into(), self.data_collection_opted_in.into(),
) )
.label("Open source repos: optionally share training data.") .label("Contribute to the open dataset when editing open source.")
.fill() .fill()
.on_click(cx.listener( .on_click(cx.listener(
move |this, state, _window, cx| { move |this, state, _window, cx| {
@ -393,14 +395,14 @@ impl Render for ZedPredictModal {
) )
) )
.child(info_item( .child(info_item(
"We ask this exclusively for open source projects.", "We collect data exclusively from open source projects.",
)) ))
.child(info_item( .child(info_item(
"Zed automatically detects if your project is open source.", "Zed automatically detects if your project is open source.",
)) ))
.child(info_item("Toggle it anytime via the status bar menu.")) .child(info_item("Toggle participation at any time via the status bar menu."))
.child(multiline_info_item( .child(multiline_info_item(
"If turned on, this setting is valid for all open source projects", "If turned on, this setting applies for all open source repositories",
label_item("you open in Zed.") label_item("you open in Zed.")
)) ))
.child(multiline_info_item( .child(multiline_info_item(
@ -425,7 +427,7 @@ impl Render for ZedPredictModal {
.gap_2() .gap_2()
.w_full() .w_full()
.child( .child(
Button::new("accept-tos", "Enable Edit Predictions") Button::new("accept-tos", "Enable Edit Prediction")
.disabled(!self.terms_of_service) .disabled(!self.terms_of_service)
.style(ButtonStyle::Tinted(TintColor::Accent)) .style(ButtonStyle::Tinted(TintColor::Accent))
.full_width() .full_width()