Channel chat: Add edit message (#9035)
**Summary**: - Removed reply message from message_menu - Made render_popover_buttons a bit more reusable - Fixed issue that you can't close the reply/edit preview when you are not focusing the message editor - Notify only the new people that were mentioned inside the edited message **Follow up** - Fix that we update the notification message for the people that we mentioned already - Fix that we remove the notification when a message gets deleted. - Fix last acknowledge message id is in correct now **Todo**: - [x] Add tests - [x] Change new added bindings to the `Editor::Cancel` event. Release Notes: - Added editing of chat messages ([#6707](https://github.com/zed-industries/zed/issues/6707)). <img width="239" alt="Screenshot 2024-03-09 at 11 55 23" src="https://github.com/zed-industries/zed/assets/62463826/b0949f0d-0f8b-43e1-ac20-4c6d40ac41e1"> <img width="240" alt="Screenshot 2024-03-13 at 13 34 23" src="https://github.com/zed-industries/zed/assets/62463826/d0636da2-c5aa-4fed-858e-4bebe5695ba7"> --------- Co-authored-by: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
This commit is contained in:
parent
5139aa3811
commit
3dadfe4787
16 changed files with 743 additions and 149 deletions
|
@ -203,7 +203,9 @@ message Envelope {
|
|||
CompleteWithLanguageModel complete_with_language_model = 166;
|
||||
LanguageModelResponse language_model_response = 167;
|
||||
CountTokensWithLanguageModel count_tokens_with_language_model = 168;
|
||||
CountTokensResponse count_tokens_response = 169; // current max
|
||||
CountTokensResponse count_tokens_response = 169;
|
||||
UpdateChannelMessage update_channel_message = 170;
|
||||
ChannelMessageUpdate channel_message_update = 171; // current max
|
||||
}
|
||||
|
||||
reserved 158 to 161;
|
||||
|
@ -1184,6 +1186,14 @@ message RemoveChannelMessage {
|
|||
uint64 message_id = 2;
|
||||
}
|
||||
|
||||
message UpdateChannelMessage {
|
||||
uint64 channel_id = 1;
|
||||
uint64 message_id = 2;
|
||||
Nonce nonce = 4;
|
||||
string body = 5;
|
||||
repeated ChatMention mentions = 6;
|
||||
}
|
||||
|
||||
message AckChannelMessage {
|
||||
uint64 channel_id = 1;
|
||||
uint64 message_id = 2;
|
||||
|
@ -1198,6 +1208,11 @@ message ChannelMessageSent {
|
|||
ChannelMessage message = 2;
|
||||
}
|
||||
|
||||
message ChannelMessageUpdate {
|
||||
uint64 channel_id = 1;
|
||||
ChannelMessage message = 2;
|
||||
}
|
||||
|
||||
message GetChannelMessages {
|
||||
uint64 channel_id = 1;
|
||||
uint64 before_message_id = 2;
|
||||
|
@ -1229,6 +1244,7 @@ message ChannelMessage {
|
|||
Nonce nonce = 5;
|
||||
repeated ChatMention mentions = 6;
|
||||
optional uint64 reply_to_message_id = 7;
|
||||
optional uint64 edited_at = 8;
|
||||
}
|
||||
|
||||
message ChatMention {
|
||||
|
|
|
@ -149,6 +149,7 @@ messages!(
|
|||
(CallCanceled, Foreground),
|
||||
(CancelCall, Foreground),
|
||||
(ChannelMessageSent, Foreground),
|
||||
(ChannelMessageUpdate, Foreground),
|
||||
(CompleteWithLanguageModel, Background),
|
||||
(CopyProjectEntry, Foreground),
|
||||
(CountTokensWithLanguageModel, Background),
|
||||
|
@ -244,6 +245,7 @@ messages!(
|
|||
(ReloadBuffersResponse, Foreground),
|
||||
(RemoveChannelMember, Foreground),
|
||||
(RemoveChannelMessage, Foreground),
|
||||
(UpdateChannelMessage, Foreground),
|
||||
(RemoveContact, Foreground),
|
||||
(RemoveProjectCollaborator, Foreground),
|
||||
(RenameChannel, Foreground),
|
||||
|
@ -358,6 +360,7 @@ request_messages!(
|
|||
(ReloadBuffers, ReloadBuffersResponse),
|
||||
(RemoveChannelMember, Ack),
|
||||
(RemoveChannelMessage, Ack),
|
||||
(UpdateChannelMessage, Ack),
|
||||
(RemoveContact, Ack),
|
||||
(RenameChannel, RenameChannelResponse),
|
||||
(RenameProjectEntry, ProjectEntryResponse),
|
||||
|
@ -442,7 +445,9 @@ entity_messages!(
|
|||
entity_messages!(
|
||||
{channel_id, Channel},
|
||||
ChannelMessageSent,
|
||||
ChannelMessageUpdate,
|
||||
RemoveChannelMessage,
|
||||
UpdateChannelMessage,
|
||||
UpdateChannelBuffer,
|
||||
UpdateChannelBufferCollaborators,
|
||||
);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue