Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make getting keybinding for display more efficient (#27046)

Browse source 
No longer iterates all the matching bindings, and no longer clones the
result.

Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2025-03-19 14:15:33 -06:00 • committed by GitHub
parent 33faa66e35
commit 3ec69a5bc0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 13 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/ui/src/components/keybinding.rs
View file

@ -33,8 +33,7 @@ impl KeyBinding {
return Self::for_action_in(action, &focused, window, cx);
}
let key_binding =
gpui::Keymap::binding_to_display_from_bindings(&window.bindings_for_action(action))
.cloned()?;
gpui::Keymap::binding_to_display_from_bindings(window.bindings_for_action(action))?;
Some(Self::new(key_binding, cx))
}
@ -46,9 +45,8 @@ impl KeyBinding {
cx: &App,
) -> Option<Self> {
let key_binding = gpui::Keymap::binding_to_display_from_bindings(
&window.bindings_for_action_in(action, focus),
)
.cloned()?;
window.bindings_for_action_in(action, focus),
)?;
Some(Self::new(key_binding, cx))
}