From 3f40d76be48a1706718fd0f777a4f851b6bdd7ce Mon Sep 17 00:00:00 2001 From: Michael Sloan Date: Wed, 18 Dec 2024 15:52:16 -0700 Subject: [PATCH] Enable search within diagnostics pane (#22213) Closes #16033 Addresses one part of #4475 Release Notes: - Added support for find and replace in diagnostics. Also causes keybindings that use search to now work (such as `*` and `#` vim bindings). --- crates/diagnostics/src/diagnostics.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/crates/diagnostics/src/diagnostics.rs b/crates/diagnostics/src/diagnostics.rs index d86676729e..13cb113acb 100644 --- a/crates/diagnostics/src/diagnostics.rs +++ b/crates/diagnostics/src/diagnostics.rs @@ -41,6 +41,7 @@ use ui::{h_flex, prelude::*, Icon, IconName, Label}; use util::ResultExt; use workspace::{ item::{BreadcrumbText, Item, ItemEvent, ItemHandle, TabContentParams}, + searchable::SearchableItemHandle, ItemNavHistory, ToolbarItemLocation, Workspace, }; @@ -810,6 +811,10 @@ impl Item for ProjectDiagnosticsEditor { } } + fn as_searchable(&self, _: &View) -> Option> { + Some(Box::new(self.editor.clone())) + } + fn breadcrumb_location(&self, _: &AppContext) -> ToolbarItemLocation { ToolbarItemLocation::PrimaryLeft }