diff --git a/crates/feature_flags/src/feature_flags.rs b/crates/feature_flags/src/feature_flags.rs index c92a8ada6c..a5dbef424f 100644 --- a/crates/feature_flags/src/feature_flags.rs +++ b/crates/feature_flags/src/feature_flags.rs @@ -69,6 +69,17 @@ impl FeatureFlag for PredictEditsRateCompletionsFeatureFlag { const NAME: &'static str = "predict-edits-rate-completions"; } +/// A feature flag that controls whether "non eager mode" (holding `alt` to preview) is publicized. +pub struct PredictEditsNonEagerModeFeatureFlag; +impl FeatureFlag for PredictEditsNonEagerModeFeatureFlag { + const NAME: &'static str = "predict-edits-non-eager-mode"; + + fn enabled_for_staff() -> bool { + // Don't show to staff so it doesn't leak into media for the launch. + false + } +} + pub struct GitUiFeatureFlag; impl FeatureFlag for GitUiFeatureFlag { const NAME: &'static str = "git-ui"; diff --git a/crates/inline_completion_button/src/inline_completion_button.rs b/crates/inline_completion_button/src/inline_completion_button.rs index 59b2c72ee4..9290839f7b 100644 --- a/crates/inline_completion_button/src/inline_completion_button.rs +++ b/crates/inline_completion_button/src/inline_completion_button.rs @@ -569,12 +569,12 @@ impl InlineCompletionButton { ); } - let is_eager_preview_enabled = match settings.edit_predictions_mode() { - language::EditPredictionsMode::Auto => false, - language::EditPredictionsMode::EagerPreview => true, - }; - menu = if cx.is_staff() { - menu.separator().toggleable_entry( + if cx.has_flag::() { + let is_eager_preview_enabled = match settings.edit_predictions_mode() { + language::EditPredictionsMode::Auto => false, + language::EditPredictionsMode::EagerPreview => true, + }; + menu = menu.separator().toggleable_entry( "Eager Preview Mode", is_eager_preview_enabled, IconPosition::Start, @@ -604,10 +604,8 @@ impl InlineCompletionButton { ); } }, - ) - } else { - menu - }; + ); + } if let Some(editor_focus_handle) = self.editor_focus_handle.clone() { menu = menu