assistant: Display edits from scripts in panel (#26441)

https://github.com/user-attachments/assets/a486ff2a-4aa1-4c0d-be6c-1dea2a8d60c8
 
- [x] Track buffer changes in `ScriptingSession`
- [x] Show edited files in thread

Reviewing diffs and displaying line counts will be part of an upcoming
PR.

Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
This commit is contained in:
Agus Zubiaga 2025-03-11 07:12:52 -03:00 committed by GitHub
parent 0df1e4a489
commit 401342c6ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 354 additions and 125 deletions

View file

@ -1,9 +1,7 @@
mod session;
mod scripting_session;
use project::Project;
use session::*;
pub use scripting_session::*;
use gpui::{App, AppContext as _, Entity, Task};
use schemars::JsonSchema;
use serde::Deserialize;
@ -24,40 +22,9 @@ impl ScriptingTool {
serde_json::to_value(&schema).unwrap()
}
pub fn run(
&self,
pub fn deserialize_input(
input: serde_json::Value,
project: Entity<Project>,
cx: &mut App,
) -> Task<anyhow::Result<String>> {
let input = match serde_json::from_value::<ScriptingToolInput>(input) {
Err(err) => return Task::ready(Err(err.into())),
Ok(input) => input,
};
// TODO: Store a session per thread
let session = cx.new(|cx| ScriptingSession::new(project, cx));
let lua_script = input.lua_script;
let (script_id, script_task) =
session.update(cx, |session, cx| session.run_script(lua_script, cx));
cx.spawn(|cx| async move {
script_task.await;
let message = session.read_with(&cx, |session, _cx| {
// Using a id to get the script output seems impractical.
// Why not just include it in the Task result?
// This is because we'll later report the script state as it runs,
// currently not supported by the `Tool` interface.
session
.get(script_id)
.output_message_for_llm()
.expect("Script shouldn't still be running")
})?;
drop(session);
Ok(message)
})
) -> Result<ScriptingToolInput, serde_json::Error> {
serde_json::from_value(input)
}
}