From 427f799018f73663be3677b19d18bd0705d57550 Mon Sep 17 00:00:00 2001 From: Eduardo Alba Date: Wed, 6 Aug 2025 10:28:41 -0400 Subject: [PATCH] Rename 'toggle theme mode' to 'cycle theme mode' --- crates/theme_selector/src/theme_selector.rs | 6 +++--- crates/zed/src/zed/app_menus.rs | 4 ++-- crates/zed_actions/src/lib.rs | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/crates/theme_selector/src/theme_selector.rs b/crates/theme_selector/src/theme_selector.rs index 8fcdb4930a..90606fedc3 100644 --- a/crates/theme_selector/src/theme_selector.rs +++ b/crates/theme_selector/src/theme_selector.rs @@ -40,9 +40,9 @@ pub fn init(cx: &mut App) { toggle_icon_theme_selector(workspace, &action, window, cx); }); }); - cx.on_action(|_: &zed_actions::theme_selector::ToggleMode, cx| { + cx.on_action(|_: &zed_actions::theme_selector::CycleMode, cx| { with_active_or_new_workspace(cx, |workspace, window, cx| { - toggle_theme_mode(workspace, window, cx); + cycle_theme_mode(workspace, window, cx); }); }); } @@ -83,7 +83,7 @@ fn toggle_icon_theme_selector( }); } -fn toggle_theme_mode(workspace: &mut Workspace, _window: &mut Window, cx: &mut Context) { +fn cycle_theme_mode(workspace: &mut Workspace, _window: &mut Window, cx: &mut Context) { let current_settings = ThemeSettings::get_global(cx); let current_selection = current_settings.theme_selection.as_ref(); diff --git a/crates/zed/src/zed/app_menus.rs b/crates/zed/src/zed/app_menus.rs index 398f35838e..bcd2372105 100644 --- a/crates/zed/src/zed/app_menus.rs +++ b/crates/zed/src/zed/app_menus.rs @@ -33,8 +33,8 @@ pub fn app_menus() -> Vec { zed_actions::theme_selector::Toggle::default(), ), MenuItem::action( - "Toggle Theme Mode", - zed_actions::theme_selector::ToggleMode, + "Cycle Theme Mode", + zed_actions::theme_selector::CycleMode, ), ], }), diff --git a/crates/zed_actions/src/lib.rs b/crates/zed_actions/src/lib.rs index 1c2fbef797..75debcb8f3 100644 --- a/crates/zed_actions/src/lib.rs +++ b/crates/zed_actions/src/lib.rs @@ -244,11 +244,11 @@ pub mod theme_selector { pub themes_filter: Option>, } - /// Toggles between light, dark, and system theme modes. + /// Cycles between light, dark, and system theme modes. #[derive(PartialEq, Clone, Default, Debug, Deserialize, JsonSchema, Action)] #[action(namespace = theme_selector)] #[serde(deny_unknown_fields)] - pub struct ToggleMode; + pub struct CycleMode; } pub mod icon_theme_selector {