Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

debugger_ui: Preview thread state when using the dropdown (#28778)

Browse source 
This PR changes the thread list dropdown menu in the debugger UI to
eagerly preview the state of a thread when selecting it, instead of
waiting until confirming the selection.

Release Notes:

- N/A
This commit is contained in:
Cole Miller 2025-04-15 12:10:32 -04:00 • committed by GitHub
parent 90dec1d451
commit 42c3f4e7cf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 104 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

78
crates/language_tools/src/lsp_log.rs
View file

@ -1421,18 +1421,21 @@ impl Render for LspLogToolbarItemView {
})
})?;
ContextMenu::build(window, cx, |mut menu, _, _| {
let log_view = log_view.clone();
ContextMenu::build(
window,
cx,
|mut menu, window, cx| {
let log_view = log_view.clone();
for (option, label) in [
(TraceValue::Off, "Off"),
(TraceValue::Messages, "Messages"),
(TraceValue::Verbose, "Verbose"),
] {
menu = menu.entry(label, None, {
let log_view = log_view.clone();
move |_, cx| {
log_view.update(cx, |this, cx| {
for (option, label) in [
(TraceValue::Off, "Off"),
(TraceValue::Messages, "Messages"),
(TraceValue::Verbose, "Verbose"),
] {
menu = menu.entry(label, None, {
let log_view = log_view.clone();
move |_, cx| {
log_view.update(cx, |this, cx| {
if let Some(id) =
this.current_server_id
{
@ -1441,15 +1444,16 @@ impl Render for LspLogToolbarItemView {
);
}
});
}
});
if option == trace_level {
menu.select_last(window, cx);
}
});
if option == trace_level {
menu.select_last();
}
}
menu
})
menu
},
)
.into()
}
}),
@ -1480,19 +1484,22 @@ impl Render for LspLogToolbarItemView {
})
})?;
ContextMenu::build(window, cx, |mut menu, _, _| {
let log_view = log_view.clone();
ContextMenu::build(
window,
cx,
|mut menu, window, cx| {
let log_view = log_view.clone();
for (option, label) in [
(MessageType::LOG, "Log"),
(MessageType::INFO, "Info"),
(MessageType::WARNING, "Warning"),
(MessageType::ERROR, "Error"),
] {
menu = menu.entry(label, None, {
let log_view = log_view.clone();
move |window, cx| {
log_view.update(cx, |this, cx| {
for (option, label) in [
(MessageType::LOG, "Log"),
(MessageType::INFO, "Info"),
(MessageType::WARNING, "Warning"),
(MessageType::ERROR, "Error"),
] {
menu = menu.entry(label, None, {
let log_view = log_view.clone();
move |window, cx| {
log_view.update(cx, |this, cx| {
if let Some(id) =
this.current_server_id
{
@ -1501,15 +1508,16 @@ impl Render for LspLogToolbarItemView {
);
}
});
}
});
if option == log_level {
menu.select_last(window, cx);
}
});
if option == log_level {
menu.select_last();
}
}
menu
})
menu
},
)
.into()
}
}),