pane: Improve close active item to better handle pinned tabs (#23488)
Closes #22247 - [x] Do not close pinned tab on keyboard shortcuts like `ctrl+w` or `alt+f4` - [x] Close pinned tab on context menu action, menu bar action, or vim bang - [x] While closing pinned tab via shortcut (where it won't close), instead activate any other non-pinned tab in same pane - [x] Else, if any other pane contains non-pinned tab, activate that - [x] Tests Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com> Release Notes: - Pinned tab now stay open when using close shortcuts, auto focuses to any other non-pinned tab instead.
This commit is contained in:
parent
f0565b4e2e
commit
44c6a54f95
9 changed files with 298 additions and 36 deletions
|
@ -257,7 +257,13 @@ impl TerminalView {
|
|||
.action("Inline Assist", Box::new(InlineAssist::default()))
|
||||
})
|
||||
.separator()
|
||||
.action("Close", Box::new(CloseActiveItem { save_intent: None }))
|
||||
.action(
|
||||
"Close",
|
||||
Box::new(CloseActiveItem {
|
||||
save_intent: None,
|
||||
close_pinned: true,
|
||||
}),
|
||||
)
|
||||
});
|
||||
|
||||
window.focus(&context_menu.focus_handle(cx));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue