Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

git_hosting_providers: Refactor constructors (#26919)

Browse source 
This PR refactors the constructors for the various Git hosting providers
to facilitate adding support for more self-hosted variants.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2025-03-17 09:46:58 -04:00 • committed by GitHub
parent 8ba6ce43ac
commit 45606abfdb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 65 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

34
crates/git_hosting_providers/src/providers/bitbucket.rs
View file

@ -7,15 +7,31 @@ use git::{
RemoteUrl,
};
pub struct Bitbucket;
pub struct Bitbucket {
name: String,
base_url: Url,
}
impl Bitbucket {
pub fn new(name: impl Into<String>, base_url: Url) -> Self {
Self {
name: name.into(),
base_url,
}
}
pub fn public_instance() -> Self {
Self::new("Bitbucket", Url::parse("https://bitbucket.org").unwrap())
}
}
impl GitHostingProvider for Bitbucket {
fn name(&self) -> String {
"Bitbucket".to_string()
self.name.clone()
}
fn base_url(&self) -> Url {
Url::parse("https://bitbucket.org").unwrap()
self.base_url.clone()
}
fn supports_avatars(&self) -> bool {
@ -90,7 +106,7 @@ mod tests {
#[test]
fn test_parse_remote_url_given_ssh_url() {
let parsed_remote = Bitbucket
let parsed_remote = Bitbucket::public_instance()
.parse_remote_url("git@bitbucket.org:zed-industries/zed.git")
.unwrap();
@ -105,7 +121,7 @@ mod tests {
#[test]
fn test_parse_remote_url_given_https_url() {
let parsed_remote = Bitbucket
let parsed_remote = Bitbucket::public_instance()
.parse_remote_url("https://bitbucket.org/zed-industries/zed.git")
.unwrap();
@ -120,7 +136,7 @@ mod tests {
#[test]
fn test_parse_remote_url_given_https_url_with_username() {
let parsed_remote = Bitbucket
let parsed_remote = Bitbucket::public_instance()
.parse_remote_url("https://thorstenballzed@bitbucket.org/zed-industries/zed.git")
.unwrap();
@ -135,7 +151,7 @@ mod tests {
#[test]
fn test_build_bitbucket_permalink() {
let permalink = Bitbucket.build_permalink(
let permalink = Bitbucket::public_instance().build_permalink(
ParsedGitRemote {
owner: "zed-industries".into(),
repo: "zed".into(),
@ -153,7 +169,7 @@ mod tests {
#[test]
fn test_build_bitbucket_permalink_with_single_line_selection() {
let permalink = Bitbucket.build_permalink(
let permalink = Bitbucket::public_instance().build_permalink(
ParsedGitRemote {
owner: "zed-industries".into(),
repo: "zed".into(),
@ -171,7 +187,7 @@ mod tests {
#[test]
fn test_build_bitbucket_permalink_with_multi_line_selection() {
let permalink = Bitbucket.build_permalink(
let permalink = Bitbucket::public_instance().build_permalink(
ParsedGitRemote {
owner: "zed-industries".into(),
repo: "zed".into(),