Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use consistent text

Browse source
This commit is contained in:
Joseph T. Lyons 2023-12-08 11:39:10 -05:00
parent b66e1d2d58
commit 4596e7a68a
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/feedback2/src/deploy_feedback_button.rs
View file

@ -32,7 +32,7 @@ impl Render for DeployFeedbackButton {
IconButton::new("give-feedback", Icon::Envelope) IconButton::new("give-feedback", Icon::Envelope)
.style(ui::ButtonStyle::Subtle) .style(ui::ButtonStyle::Subtle)
.selected(is_open) .selected(is_open)
.tooltip(|cx| Tooltip::text("Give Feedback", cx)) .tooltip(|cx| Tooltip::text("Share Feedback", cx))
.on_click(|_, cx| { .on_click(|_, cx| {
cx.dispatch_action(Box::new(GiveFeedback)); cx.dispatch_action(Box::new(GiveFeedback));
}) })

6
crates/feedback2/src/feedback_modal.rs
View file

@ -263,9 +263,9 @@ impl Render for FeedbackModal {
let has_feedback = self.feedback_editor.read(cx).text_option(cx).is_some(); let has_feedback = self.feedback_editor.read(cx).text_option(cx).is_some();
let submit_button_text = if self.pending_submission { let submit_button_text = if self.pending_submission {
"Sending..." "Submitting..."
} else { } else {
"Send Feedback" "Submit"
}; };
let dismiss = cx.listener(|_, _, cx| { let dismiss = cx.listener(|_, _, cx| {
cx.emit(DismissEvent); cx.emit(DismissEvent);
@ -379,7 +379,7 @@ impl Render for FeedbackModal {
.color(Color::Accent) .color(Color::Accent)
.style(ButtonStyle::Filled) .style(ButtonStyle::Filled)
// TODO: Ensure that while submitting, "Sending..." is shown and disable the button // TODO: Ensure that while submitting, "Sending..." is shown and disable the button
// TODO: If submit errors: show popup with error, don't close modal, set text back to "Send Feedback", and re-enable button // TODO: If submit errors: show popup with error, don't close modal, set text back to "Submit", and re-enable button
// TODO: If submit is successful, close the modal // TODO: If submit is successful, close the modal
.on_click(cx.listener(|this, _, cx| { .on_click(cx.listener(|this, _, cx| {
let _ = this.submit(cx); let _ = this.submit(cx);