Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add test for notifying and dropping subscriptions in an update cycle

Browse source
This commit is contained in:
Max Brunsfeld 2023-01-06 10:44:37 -08:00
parent a165cd596b
commit 4708f5d88f
2 changed files with 28 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/gpui/src/app/callback_collection.rs
View file

@ -58,14 +58,6 @@ impl<K: Clone + Hash + Eq + Copy, F> CallbackCollection<K, F> {
}
}
pub fn count(&mut self, key: K) -> usize {
self.internal
.lock()
.callbacks
.get(&key)
.map_or(0, |callbacks| callbacks.len())
}
pub fn add_callback(&mut self, key: K, subscription_id: usize, callback: F) {
let mut this = self.internal.lock();
if !this.dropped_subscriptions.contains(&(key, subscription_id)) {
@ -77,7 +69,9 @@ impl<K: Clone + Hash + Eq + Copy, F> CallbackCollection<K, F> {
}
pub fn remove(&mut self, key: K) {
self.internal.lock().callbacks.remove(&key);
let callbacks = self.internal.lock().callbacks.remove(&key);
// drop these after releasing the lock
drop(callbacks);
}
pub fn emit<C: FnMut(&mut F, &mut MutableAppContext) -> bool>(