diff --git a/assets/keymaps/default-linux.json b/assets/keymaps/default-linux.json index 75090203be..6e9a2dc406 100644 --- a/assets/keymaps/default-linux.json +++ b/assets/keymaps/default-linux.json @@ -767,13 +767,7 @@ } }, { - "context": "FileFinder", - "bindings": { - "ctrl": "file_finder::ToggleMenu" - } - }, - { - "context": "FileFinder && !menu_open", + "context": "FileFinder || (FileFinder > Picker > Editor) || (FileFinder > Picker > menu)", "bindings": { "ctrl-shift-p": "file_finder::SelectPrev", "ctrl-j": "pane::SplitDown", @@ -782,15 +776,6 @@ "ctrl-l": "pane::SplitRight" } }, - { - "context": "FileFinder && menu_open", - "bindings": { - "j": "pane::SplitDown", - "k": "pane::SplitUp", - "h": "pane::SplitLeft", - "l": "pane::SplitRight" - } - }, { "context": "TabSwitcher", "bindings": { diff --git a/assets/keymaps/default-macos.json b/assets/keymaps/default-macos.json index 8e055677fd..5d52deea67 100644 --- a/assets/keymaps/default-macos.json +++ b/assets/keymaps/default-macos.json @@ -785,14 +785,7 @@ } }, { - "context": "FileFinder", - "use_key_equivalents": true, - "bindings": { - "cmd": "file_finder::ToggleMenu" - } - }, - { - "context": "FileFinder && !menu_open", + "context": "FileFinder || (FileFinder > Picker > Editor) || (FileFinder > Picker > menu)", "use_key_equivalents": true, "bindings": { "cmd-shift-p": "file_finder::SelectPrev", @@ -802,16 +795,6 @@ "cmd-l": "pane::SplitRight" } }, - { - "context": "FileFinder && menu_open", - "use_key_equivalents": true, - "bindings": { - "j": "pane::SplitDown", - "k": "pane::SplitUp", - "h": "pane::SplitLeft", - "l": "pane::SplitRight" - } - }, { "context": "TabSwitcher", "use_key_equivalents": true, diff --git a/crates/file_finder/src/file_finder.rs b/crates/file_finder/src/file_finder.rs index e9f7c01683..c15f965db0 100644 --- a/crates/file_finder/src/file_finder.rs +++ b/crates/file_finder/src/file_finder.rs @@ -34,7 +34,7 @@ use std::{ }; use text::Point; use ui::{ - prelude::*, ContextMenu, HighlightedLabel, KeyBinding, ListItem, ListItemSpacing, PopoverMenu, + prelude::*, ContextMenu, HighlightedLabel, ListItem, ListItemSpacing, PopoverMenu, PopoverMenuHandle, }; use util::{paths::PathWithPosition, post_inc, ResultExt}; @@ -1448,11 +1448,7 @@ impl PickerDelegate for FileFinderDelegate { ) } - fn render_footer( - &self, - window: &mut Window, - cx: &mut Context>, - ) -> Option { + fn render_footer(&self, _: &mut Window, cx: &mut Context>) -> Option { let context = self.focus_handle.clone(); Some( h_flex() @@ -1463,11 +1459,9 @@ impl PickerDelegate for FileFinderDelegate { .border_t_1() .border_color(cx.theme().colors().border_variant) .child( - Button::new("open-selection", "Open") - .key_binding(KeyBinding::for_action(&menu::Confirm, window, cx)) - .on_click(|_, window, cx| { - window.dispatch_action(menu::Confirm.boxed_clone(), cx) - }), + Button::new("open-selection", "Open").on_click(|_, window, cx| { + window.dispatch_action(menu::Confirm.boxed_clone(), cx) + }), ) .child( PopoverMenu::new("menu-popover") @@ -1475,14 +1469,8 @@ impl PickerDelegate for FileFinderDelegate { .attach(gpui::Corner::TopRight) .anchor(gpui::Corner::BottomRight) .trigger( - Button::new("actions-trigger", "Split Options") - .selected_label_color(Color::Accent) - .key_binding(KeyBinding::for_action_in( - &ToggleMenu, - &context, - window, - cx, - )), + Button::new("actions-trigger", "Split…") + .selected_label_color(Color::Accent), ) .menu({ move |window, cx| {