windows: Fix eslint
installation (#15331)
Close #13786. To make `eslint` running on Windows, I made the following changes: 1. Ensure that `zed` downloads the `.zip` file. 2. Handle the `$shared` symbolic link by copying files to the link location. 3. In #13891, I mentioned that the `npm` `post-install` script was always failing. After debugging, I found it was due to missing environment variables. This has been fixed, and I will submit a new PR to address the changes in #13891. With this PR, `eslint` can now successfully run on Windows. Video: https://github.com/user-attachments/assets/e85451b8-0388-490a-8a75-01c12d744f7c Release Notes: - Fixed `eslint` not running on Windows ([#13786](https://github.com/zed-industries/zed/issues/13786)). --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
This commit is contained in:
parent
138c3fcfdd
commit
4976a9e9d8
3 changed files with 59 additions and 0 deletions
|
@ -120,6 +120,7 @@ pub async fn get_release_by_tag_name(
|
|||
#[derive(Debug, PartialEq, Eq, Clone, Copy)]
|
||||
pub enum AssetKind {
|
||||
TarGz,
|
||||
Zip,
|
||||
}
|
||||
|
||||
pub fn build_asset_url(repo_name_with_owner: &str, tag: &str, kind: AssetKind) -> Result<String> {
|
||||
|
@ -132,6 +133,7 @@ pub fn build_asset_url(repo_name_with_owner: &str, tag: &str, kind: AssetKind) -
|
|||
"{tag}.{extension}",
|
||||
extension = match kind {
|
||||
AssetKind::TarGz => "tar.gz",
|
||||
AssetKind::Zip => "zip",
|
||||
}
|
||||
);
|
||||
url.path_segments_mut()
|
||||
|
@ -154,5 +156,11 @@ mod tests {
|
|||
tarball,
|
||||
"https://github.com/microsoft/vscode-eslint/archive/refs/tags/release%2F2.3.5.tar.gz"
|
||||
);
|
||||
|
||||
let zip = build_asset_url(repo_name_with_owner, tag, AssetKind::Zip).unwrap();
|
||||
assert_eq!(
|
||||
zip,
|
||||
"https://github.com/microsoft/vscode-eslint/archive/refs/tags/release%2F2.3.5.zip"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue