Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable clippy::useless_conversion (#8724)

Browse source 
This PR enables the
[`clippy::useless_conversion`](https://rust-lang.github.io/rust-clippy/master/index.html#/useless_conversion)
rule and fixes the outstanding violations.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-03-02 16:31:47 -05:00 • committed by GitHub
parent 87efb75e53
commit 4b81b15cad
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
21 changed files with 44 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/language/src/outline.rs
View file

@ -43,7 +43,7 @@ impl<T> Outline<T> {
let candidate_text = item
.name_ranges
.iter()
.map(|range| &item.text[range.start as usize..range.end as usize])
.map(|range| &item.text[range.start..range.end])
.collect::<String>();
path_candidates.push(StringMatchCandidate::new(id, path_text.clone()));
@ -97,11 +97,11 @@ impl<T> Outline<T> {
let mut name_range = name_ranges.next().unwrap();
let mut preceding_ranges_len = 0;
for position in &mut string_match.positions {
while *position >= preceding_ranges_len + name_range.len() as usize {
while *position >= preceding_ranges_len + name_range.len() {
preceding_ranges_len += name_range.len();
name_range = name_ranges.next().unwrap();
}
*position = name_range.start as usize + (*position - preceding_ranges_len);
*position = name_range.start + (*position - preceding_ranges_len);
}
}

2
crates/language/src/syntax_map.rs
View file

@ -1421,7 +1421,7 @@ fn insert_newlines_between_ranges(
if range_a.end_point.row < range_b.start_point.row {
let end_point = start_point + Point::from_ts_point(range_a.end_point);
let line_end = Point::new(end_point.row, text.line_len(end_point.row));
if end_point.column as u32 >= line_end.column {
if end_point.column >= line_end.column {
range_a.end_byte += 1;
range_a.end_point.row += 1;
range_a.end_point.column = 0;