Add is_via_ssh field to editor events (#18837)

Release Notes:

- N/A
This commit is contained in:
Joseph T. Lyons 2024-10-08 10:30:04 -04:00 committed by GitHub
parent dd44168cad
commit 4c7a6f5e7f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 9 additions and 1 deletions

View file

@ -364,6 +364,7 @@ impl Telemetry {
operation: &'static str, operation: &'static str,
copilot_enabled: bool, copilot_enabled: bool,
copilot_enabled_for_language: bool, copilot_enabled_for_language: bool,
is_via_ssh: bool,
) { ) {
let event = Event::Editor(EditorEvent { let event = Event::Editor(EditorEvent {
file_extension, file_extension,
@ -371,6 +372,7 @@ impl Telemetry {
operation: operation.into(), operation: operation.into(),
copilot_enabled, copilot_enabled,
copilot_enabled_for_language, copilot_enabled_for_language,
is_via_ssh,
}); });
self.report_event(event) self.report_event(event)

View file

@ -679,6 +679,7 @@ pub struct EditorEventRow {
minor: Option<i32>, minor: Option<i32>,
patch: Option<i32>, patch: Option<i32>,
checksum_matched: bool, checksum_matched: bool,
is_via_ssh: bool,
} }
impl EditorEventRow { impl EditorEventRow {
@ -720,6 +721,7 @@ impl EditorEventRow {
region_code: "".to_string(), region_code: "".to_string(),
city: "".to_string(), city: "".to_string(),
historical_event: false, historical_event: false,
is_via_ssh: event.is_via_ssh,
} }
} }
} }

View file

@ -12481,13 +12481,15 @@ impl Editor {
.settings_at(0, cx) .settings_at(0, cx)
.show_inline_completions; .show_inline_completions;
let telemetry = project.read(cx).client().telemetry().clone(); let project = project.read(cx);
let telemetry = project.client().telemetry().clone();
telemetry.report_editor_event( telemetry.report_editor_event(
file_extension, file_extension,
vim_mode, vim_mode,
operation, operation,
copilot_enabled, copilot_enabled,
copilot_enabled_for_language, copilot_enabled_for_language,
project.is_via_ssh(),
) )
} }

View file

@ -117,6 +117,8 @@ pub struct EditorEvent {
pub copilot_enabled: bool, pub copilot_enabled: bool,
/// Whether the user has copilot enabled for the language of the file opened or saved /// Whether the user has copilot enabled for the language of the file opened or saved
pub copilot_enabled_for_language: bool, pub copilot_enabled_for_language: bool,
/// Whether the client is editing a local file or a remote file via SSH
pub is_via_ssh: bool,
} }
/// Deprecated since Zed v0.137.0 (2024-05-29). Replaced by InlineCompletionEvent. /// Deprecated since Zed v0.137.0 (2024-05-29). Replaced by InlineCompletionEvent.