Hide old linux panics (#13221)

Remove noise from the #panics channel by excluding any linux build
before
0.139.x. We filter on the os_version and os_name because evern older
versions
of linux set app_version = 1.0.0.

Release Notes:

- N/A
This commit is contained in:
Conrad Irwin 2024-06-18 13:48:26 -06:00 committed by GitHub
parent 89d2ace713
commit 4f364d6d09
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -308,13 +308,12 @@ pub async fn post_panic(
.map_err(|_| Error::Http(StatusCode::BAD_REQUEST, "invalid json".into()))?; .map_err(|_| Error::Http(StatusCode::BAD_REQUEST, "invalid json".into()))?;
let panic = report.panic; let panic = report.panic;
// better OS reporting for linux (because linux is hard): if panic.os_name == "Linux" && panic.os_version == Some("1.0.0".to_string()) {
// - Remove os_version/app_version/os_name from the gpui platform trait return Err(Error::Http(
// - Move platform processing data into client/telemetry StatusCode::BAD_REQUEST,
// - Duplicate some small code in macOS platform for a version check "invalid os version".into(),
// - Add GPUI API for reporting the selected platform integration ))?;
// - macos-blade, macos-metal, linux-X11, linux-headless }
// if cfg(macos( { "Macos" } else { "Linux-{cx.compositor_name()"} ))
tracing::error!( tracing::error!(
service = "client", service = "client",