Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix editor::GoToDiagnostics cycle (#24446)

Browse source 
https://github.com/user-attachments/assets/45f665f0-473a-49bd-b013-b9d1bdb902bd


After activating 2nd diagnostics group, `find_map` code for next
diagnostics did not skip the previous group for the same place.

Release Notes:

- Fixed `editor::GoToDiagnostics` action stuck when multiple diagnostics
groups belong to the same place
This commit is contained in:
Kirill Bulatov 2025-02-07 16:49:13 +02:00 • committed by GitHub
parent b6b06cf6d8
commit 4f65cfa93d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 188 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

24
crates/editor/src/editor.rs
View file

@ -10283,14 +10283,26 @@ impl Editor {
if entry.diagnostic.is_primary
&& entry.diagnostic.severity <= DiagnosticSeverity::WARNING
&& entry.range.start != entry.range.end
// if we match with the active diagnostic, skip it
&& Some(entry.diagnostic.group_id)
!= self.active_diagnostics.as_ref().map(|d| d.group_id)
{
Some((entry.range, entry.diagnostic.group_id))
} else {
None
let entry_group = entry.diagnostic.group_id;
let in_next_group = self.active_diagnostics.as_ref().map_or(
true,
|active| match direction {
Direction::Prev => {
entry_group != active.group_id
&& (active.group_id == 0 || entry_group < active.group_id)
}
Direction::Next => {
entry_group != active.group_id
&& (entry_group == 0 || entry_group > active.group_id)
}
},
);
if in_next_group {
return Some((entry.range, entry.diagnostic.group_id));
}
}
None
});
if let Some((primary_range, group_id)) = group {