Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Actually fail on clippy failures (#7619)

Browse source 
Before the change to `script/clippy`, bash ignored first `clippy`
invocation failure and CI moved on with Linux errors and warnings
emitted.


Release Notes:

- N/A

---------

Co-authored-by: Mikayla Maki <mikayla@zed.dev>
This commit is contained in:
Kirill Bulatov 2024-02-09 20:13:00 +02:00 • committed by GitHub
parent eee00c3fef
commit 5175c8963a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 208 additions and 154 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/gpui/src/platform/linux/platform.rs
View file

@ -59,7 +59,7 @@ pub(crate) struct LinuxPlatform {
pub(crate) struct LinuxPlatformState {
quit_requested: bool,
windows: HashMap<x::Window, Arc<LinuxWindowState>>,
windows: HashMap<x::Window, Rc<LinuxWindowState>>,
}
impl Default for LinuxPlatform {
@ -133,7 +133,7 @@ impl Platform for LinuxPlatform {
xcb::Event::X(x::Event::Expose(ev)) => {
let window = {
let state = self.state.lock();
Arc::clone(&state.windows[&ev.window()])
Rc::clone(&state.windows[&ev.window()])
};
window.expose();
}
@ -150,7 +150,7 @@ impl Platform for LinuxPlatform {
};
let window = {
let state = self.state.lock();
Arc::clone(&state.windows[&ev.window()])
Rc::clone(&state.windows[&ev.window()])
};
window.configure(bounds)
}
@ -217,7 +217,7 @@ impl Platform for LinuxPlatform {
) -> Box<dyn PlatformWindow> {
let x_window = self.xcb_connection.generate_id();
let window_ptr = Arc::new(LinuxWindowState::new(
let window_ptr = Rc::new(LinuxWindowState::new(
options,
&self.xcb_connection,
self.x_root_index,
@ -228,7 +228,7 @@ impl Platform for LinuxPlatform {
self.state
.lock()
.windows
.insert(x_window, Arc::clone(&window_ptr));
.insert(x_window, Rc::clone(&window_ptr));
Box::new(LinuxWindow(window_ptr))
}