Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't assign invite code when updating count from 0 to 0

Browse source 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
This commit is contained in:
Nathan Sobo 2022-05-23 17:28:05 -06:00
parent 4b8f24c84e
commit 51a61cc485
1 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

21
crates/collab/src/db.rs
View file

@ -228,17 +228,20 @@ impl Db for PostgresDb {
async fn set_invite_count(&self, id: UserId, count: u32) -> Result<()> { async fn set_invite_count(&self, id: UserId, count: u32) -> Result<()> {
let mut tx = self.pool.begin().await?; let mut tx = self.pool.begin().await?;
sqlx::query( if count > 0 {
" sqlx::query(
"
UPDATE users UPDATE users
SET invite_code = $1 SET invite_code = $1
WHERE id = $2 AND invite_code IS NULL WHERE id = $2 AND invite_code IS NULL
", ",
) )
.bind(nanoid!(16)) .bind(nanoid!(16))
.bind(id) .bind(id)
.execute(&mut tx) .execute(&mut tx)
.await?; .await?;
}
sqlx::query( sqlx::query(
" "
UPDATE users UPDATE users
@ -1394,6 +1397,10 @@ pub mod tests {
// Initially, user 1 has no invite code // Initially, user 1 has no invite code
assert_eq!(db.get_invite_code_for_user(user1).await.unwrap(), None); assert_eq!(db.get_invite_code_for_user(user1).await.unwrap(), None);
// Setting invite count to 0 when no code is assigned does not assign a new code
db.set_invite_count(user1, 0).await.unwrap();
assert!(db.get_invite_code_for_user(user1).await.unwrap().is_none());
// User 1 creates an invite code that can be used twice. // User 1 creates an invite code that can be used twice.
db.set_invite_count(user1, 2).await.unwrap(); db.set_invite_count(user1, 2).await.unwrap();
let (invite_code, invite_count) = let (invite_code, invite_count) =