Reorder items in the quick action bar (#34203)

Namely, putting the diagnostics items in their own little section,
divider from the other "inline" and minimap/edit prediction items. I
feel like this is an easier to parse organization, even though all the
"inlines" made sense to be somewhat close together.

Release Notes:

- N/A
This commit is contained in:
Danilo Leal 2025-07-10 09:49:19 -03:00 committed by GitHub
parent 3169f06404
commit 51c24e2010
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -338,52 +338,6 @@ impl Render for QuickActionBar {
);
}
if supports_diagnostics {
menu = menu.toggleable_entry(
"Diagnostics",
diagnostics_enabled,
IconPosition::Start,
Some(ToggleDiagnostics.boxed_clone()),
{
let editor = editor.clone();
move |window, cx| {
editor
.update(cx, |editor, cx| {
editor.toggle_diagnostics(
&ToggleDiagnostics,
window,
cx,
);
})
.ok();
}
},
);
if supports_inline_diagnostics {
menu = menu.toggleable_entry(
"Inline Diagnostics",
inline_diagnostics_enabled,
IconPosition::Start,
Some(ToggleInlineDiagnostics.boxed_clone()),
{
let editor = editor.clone();
move |window, cx| {
editor
.update(cx, |editor, cx| {
editor.toggle_inline_diagnostics(
&ToggleInlineDiagnostics,
window,
cx,
);
})
.ok();
}
},
);
}
}
if supports_minimap {
menu = menu.toggleable_entry("Minimap", minimap_enabled, IconPosition::Start, Some(editor::actions::ToggleMinimap.boxed_clone()), {
let editor = editor.clone();
@ -432,6 +386,54 @@ impl Render for QuickActionBar {
menu = menu.separator();
if supports_diagnostics {
menu = menu.toggleable_entry(
"Diagnostics",
diagnostics_enabled,
IconPosition::Start,
Some(ToggleDiagnostics.boxed_clone()),
{
let editor = editor.clone();
move |window, cx| {
editor
.update(cx, |editor, cx| {
editor.toggle_diagnostics(
&ToggleDiagnostics,
window,
cx,
);
})
.ok();
}
},
);
if supports_inline_diagnostics {
menu = menu.toggleable_entry(
"Inline Diagnostics",
inline_diagnostics_enabled,
IconPosition::Start,
Some(ToggleInlineDiagnostics.boxed_clone()),
{
let editor = editor.clone();
move |window, cx| {
editor
.update(cx, |editor, cx| {
editor.toggle_inline_diagnostics(
&ToggleInlineDiagnostics,
window,
cx,
);
})
.ok();
}
},
);
}
menu = menu.separator();
}
menu = menu.toggleable_entry(
"Line Numbers",
show_line_numbers,