From 543a7b123ae1084076a95fa0572b95b7fe6d0864 Mon Sep 17 00:00:00 2001 From: Cole Miller Date: Fri, 4 Jul 2025 13:33:10 -0400 Subject: [PATCH] debugger: Fix errors in JavaScript DAP schema (#33884) `program` isn't required, and in fact our built-in `JavaScript debug terminal` configuration doesn't have it. Also add `node-terminal` to the list of allowed types. Co-authored-by: Michael Release Notes: - N/A --- crates/dap_adapters/src/javascript.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/crates/dap_adapters/src/javascript.rs b/crates/dap_adapters/src/javascript.rs index 23a378cdf9..d261d3b8b6 100644 --- a/crates/dap_adapters/src/javascript.rs +++ b/crates/dap_adapters/src/javascript.rs @@ -245,7 +245,7 @@ impl DebugAdapter for JsDebugAdapter { "properties": { "type": { "type": "string", - "enum": ["pwa-node", "node", "chrome", "pwa-chrome", "msedge", "pwa-msedge"], + "enum": ["pwa-node", "node", "chrome", "pwa-chrome", "msedge", "pwa-msedge", "node-terminal"], "description": "The type of debug session", "default": "pwa-node" }, @@ -379,10 +379,6 @@ impl DebugAdapter for JsDebugAdapter { } } }, - "oneOf": [ - { "required": ["program"] }, - { "required": ["url"] } - ] } ] },