Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Deflake fs::test_event_stream_simple (#24013)

Browse source 
Should reduce test flakiness

Release Notes:

- N/A
This commit is contained in:
Conrad Irwin 2025-01-30 23:53:36 -07:00 • committed by GitHub
parent 8be73bf187
commit 5914ccdc51
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/fsevent/src/fsevent.rs
View file

@ -398,8 +398,15 @@ mod tests {
assert!(event.flags.contains(StreamFlags::ITEM_CREATED)); assert!(event.flags.contains(StreamFlags::ITEM_CREATED));
fs::remove_file(path.join("existing-file-5")).unwrap(); fs::remove_file(path.join("existing-file-5")).unwrap();
let events = rx.recv_timeout(Duration::from_secs(2)).unwrap(); let mut events = rx.recv_timeout(Duration::from_secs(2)).unwrap();
let event = events.last().unwrap(); let mut event = events.last().unwrap();
// we see this duplicate about 1/100 test runs.
if event.path == path.join("new-file")
&& event.flags.contains(StreamFlags::ITEM_CREATED)
{
events = rx.recv_timeout(Duration::from_secs(2)).unwrap();
event = events.last().unwrap();
}
assert_eq!(event.path, path.join("existing-file-5")); assert_eq!(event.path, path.join("existing-file-5"));
assert!(event.flags.contains(StreamFlags::ITEM_REMOVED)); assert!(event.flags.contains(StreamFlags::ITEM_REMOVED));
drop(handle); drop(handle);