collab ui: Dismiss project shared notifications when leaving room (#10160)
When leaving a call/room in which a project was shared, the shared project notification was not getting dismissed when the person that shared the project left the room. Although there was a `cx.emit(Event::Left)` call inside room, the event was never received in the `project_shared_notification` module, because the room is dropped before the event can be dispatched. Moving the `cx.emit(Event::Left)` to the active call fixed the problem. Also renamed `Event::Left` to `Event::RoomLeft` because the room join equivalent is also called `Event::RoomJoined`. Release Notes: - Fixed project shared notification staying open, when the user that shared the project left the room
This commit is contained in:
parent
8e9543aefe
commit
5b4ff74dca
5 changed files with 24 additions and 6 deletions
|
@ -156,7 +156,7 @@ impl ChatPanel {
|
|||
}
|
||||
}
|
||||
}
|
||||
room::Event::Left { channel_id } => {
|
||||
room::Event::RoomLeft { channel_id } => {
|
||||
if channel_id == &this.channel_id(cx) {
|
||||
cx.emit(PanelEvent::Close)
|
||||
}
|
||||
|
|
|
@ -58,7 +58,7 @@ pub fn init(app_state: &Arc<AppState>, cx: &mut AppContext) {
|
|||
}
|
||||
}
|
||||
|
||||
room::Event::Left { .. } => {
|
||||
room::Event::RoomLeft { .. } => {
|
||||
for (_, windows) in notification_windows.drain() {
|
||||
for window in windows {
|
||||
window
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue