Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Diagnostics small fixes (#28817)

Browse source 
- **Clear diagnostics cache when toggling warnings**
- **Fix focus when first adding excerpts**

Closes #ISSUE

Release Notes:

- N/A *or* Added/Fixed/Improved ...
This commit is contained in:
Conrad Irwin 2025-04-15 16:42:04 -06:00 • committed by GitHub
parent f1f5d602fc
commit 5d3718df2d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
crates/diagnostics/src/diagnostics.rs
View file

@ -209,6 +209,7 @@ impl ProjectDiagnosticsEditor {
.detach(); .detach();
cx.observe_global_in::<IncludeWarnings>(window, |this, window, cx| { cx.observe_global_in::<IncludeWarnings>(window, |this, window, cx| {
this.include_warnings = cx.global::<IncludeWarnings>().0; this.include_warnings = cx.global::<IncludeWarnings>().0;
this.diagnostics.clear();
this.update_all_excerpts(window, cx); this.update_all_excerpts(window, cx);
}) })
.detach(); .detach();
@ -300,11 +301,8 @@ impl ProjectDiagnosticsEditor {
} }
} }
fn toggle_warnings(&mut self, _: &ToggleWarnings, window: &mut Window, cx: &mut Context<Self>) { fn toggle_warnings(&mut self, _: &ToggleWarnings, _: &mut Window, cx: &mut Context<Self>) {
self.include_warnings = !self.include_warnings; cx.set_global(IncludeWarnings(!self.include_warnings));
cx.set_global(IncludeWarnings(self.include_warnings));
self.update_all_excerpts(window, cx);
cx.notify();
} }
fn focus_in(&mut self, window: &mut Window, cx: &mut Context<Self>) { fn focus_in(&mut self, window: &mut Window, cx: &mut Context<Self>) {
@ -482,7 +480,10 @@ impl ProjectDiagnosticsEditor {
editor.change_selections(Some(Autoscroll::fit()), window, cx, |s| { editor.change_selections(Some(Autoscroll::fit()), window, cx, |s| {
s.select_anchor_ranges([range_to_select]); s.select_anchor_ranges([range_to_select]);
}) })
}) });
if this.focus_handle.is_focused(window) {
this.editor.read(cx).focus_handle(cx).focus(window);
}
} }
} }