Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove some todo!'s

Browse source
This commit is contained in:
Kirill Bulatov 2024-01-09 10:13:40 +02:00
parent aa1d2d2f24
commit 625c9d8980
14 changed files with 18 additions and 211 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/gpui/src/action.rs
View file

@ -203,7 +203,6 @@ macro_rules! __impl_action {
)
}
// todo!() why is this needed in addition to name?
fn debug_name() -> &'static str
where
Self: ::std::marker::Sized

5
crates/gpui/src/app/test_context.rs
View file

@ -467,12 +467,11 @@ impl<V> View<V> {
}
}
// todo!(start_waiting)
// cx.borrow().foreground_executor().start_waiting();
cx.borrow().background_executor().start_waiting();
rx.recv()
.await
.expect("view dropped with pending condition");
// cx.borrow().foreground_executor().finish_waiting();
cx.borrow().background_executor().finish_waiting();
}
})
.await

2
crates/gpui/src/elements/overlay.rs
View file

@ -14,8 +14,8 @@ pub struct Overlay {
children: SmallVec<[AnyElement; 2]>,
anchor_corner: AnchorCorner,
fit_mode: OverlayFitMode,
// todo!();
anchor_position: Option<Point<Pixels>>,
// todo!();
// position_mode: OverlayPositionMode,
}

2
crates/gpui/src/platform/test/display.rs
View file

@ -32,7 +32,7 @@ impl PlatformDisplay for TestDisplay {
}
fn as_any(&self) -> &dyn std::any::Any {
todo!()
unimplemented!()
}
fn bounds(&self) -> crate::Bounds<crate::GlobalPixels> {

1
crates/gpui/src/platform/test/platform.rs
View file

@ -103,7 +103,6 @@ impl TestPlatform {
}
}
// todo!("implement out what our tests needed in GPUI 1")
impl Platform for TestPlatform {
fn background_executor(&self) -> BackgroundExecutor {
self.background_executor.clone()