Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow too many arguments (#26375)

Browse source 
This is nearly half of our #allows, and seems like something we happily
break whenever we need

Release Notes:

- N/A
This commit is contained in:
Conrad Irwin 2025-03-10 13:38:30 -06:00 • committed by GitHub
parent 659fae70f8
commit 63091459d8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
48 changed files with 4 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Cargo.toml
View file

@ -751,5 +751,9 @@ new_ret_no_self = { level = "allow" }
should_implement_trait = { level = "allow" } should_implement_trait = { level = "allow" }
let_underscore_future = "allow" let_underscore_future = "allow"
# in Rust it can be very tedious to reduce argument count without
# running afoul of the borrow checker.
too_many_arguments = "allow"
[workspace.metadata.cargo-machete] [workspace.metadata.cargo-machete]
ignored = ["bindgen", "cbindgen", "prost_build", "serde", "component", "linkme"] ignored = ["bindgen", "cbindgen", "prost_build", "serde", "component", "linkme"]

3
crates/assistant/src/inline_assistant.rs
View file

@ -386,7 +386,6 @@ impl InlineAssistant {
} }
} }
#[allow(clippy::too_many_arguments)]
pub fn suggest_assist( pub fn suggest_assist(
&mut self, &mut self,
editor: &Entity<Editor>, editor: &Entity<Editor>,
@ -1674,7 +1673,6 @@ impl Focusable for PromptEditor {
impl PromptEditor { impl PromptEditor {
const MAX_LINES: u8 = 8; const MAX_LINES: u8 = 8;
#[allow(clippy::too_many_arguments)]
fn new( fn new(
id: InlineAssistId, id: InlineAssistId,
gutter_dimensions: Arc<Mutex<GutterDimensions>>, gutter_dimensions: Arc<Mutex<GutterDimensions>>,
@ -2333,7 +2331,6 @@ struct InlineAssist {
} }
impl InlineAssist { impl InlineAssist {
#[allow(clippy::too_many_arguments)]
fn new( fn new(
assist_id: InlineAssistId, assist_id: InlineAssistId,
group_id: InlineAssistGroupId, group_id: InlineAssistGroupId,

1
crates/assistant/src/terminal_inline_assistant.rs
View file

@ -702,7 +702,6 @@ impl Focusable for PromptEditor {
impl PromptEditor { impl PromptEditor {
const MAX_LINES: u8 = 8; const MAX_LINES: u8 = 8;
#[allow(clippy::too_many_arguments)]
fn new( fn new(
id: TerminalInlineAssistId, id: TerminalInlineAssistId,
prompt_history: VecDeque<String>, prompt_history: VecDeque<String>,

1
crates/assistant2/src/context_strip.rs
View file

@ -36,7 +36,6 @@ pub struct ContextStrip {
} }
impl ContextStrip { impl ContextStrip {
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
context_store: Entity<ContextStore>, context_store: Entity<ContextStore>,
workspace: WeakEntity<Workspace>, workspace: WeakEntity<Workspace>,

3
crates/assistant2/src/inline_assistant.rs
View file

@ -480,7 +480,6 @@ impl InlineAssistant {
} }
} }
#[allow(clippy::too_many_arguments)]
pub fn suggest_assist( pub fn suggest_assist(
&mut self, &mut self,
editor: &Entity<Editor>, editor: &Entity<Editor>,
@ -1451,7 +1450,6 @@ struct InlineAssistScrollLock {
} }
impl EditorInlineAssists { impl EditorInlineAssists {
#[allow(clippy::too_many_arguments)]
fn new(editor: &Entity<Editor>, window: &mut Window, cx: &mut App) -> Self { fn new(editor: &Entity<Editor>, window: &mut Window, cx: &mut App) -> Self {
let (highlight_updates_tx, mut highlight_updates_rx) = async_watch::channel(()); let (highlight_updates_tx, mut highlight_updates_rx) = async_watch::channel(());
Self { Self {
@ -1563,7 +1561,6 @@ pub struct InlineAssist {
} }
impl InlineAssist { impl InlineAssist {
#[allow(clippy::too_many_arguments)]
fn new( fn new(
assist_id: InlineAssistId, assist_id: InlineAssistId,
group_id: InlineAssistGroupId, group_id: InlineAssistGroupId,

2
crates/assistant2/src/inline_prompt_editor.rs
View file

@ -816,7 +816,6 @@ impl InlineAssistId {
} }
impl PromptEditor<BufferCodegen> { impl PromptEditor<BufferCodegen> {
#[allow(clippy::too_many_arguments)]
pub fn new_buffer( pub fn new_buffer(
id: InlineAssistId, id: InlineAssistId,
gutter_dimensions: Arc<Mutex<GutterDimensions>>, gutter_dimensions: Arc<Mutex<GutterDimensions>>,
@ -976,7 +975,6 @@ impl TerminalInlineAssistId {
} }
impl PromptEditor<TerminalCodegen> { impl PromptEditor<TerminalCodegen> {
#[allow(clippy::too_many_arguments)]
pub fn new_terminal( pub fn new_terminal(
id: TerminalInlineAssistId, id: TerminalInlineAssistId,
prompt_history: VecDeque<String>, prompt_history: VecDeque<String>,

2
crates/assistant_context_editor/src/context.rs
View file

@ -647,7 +647,6 @@ impl AssistantContext {
) )
} }
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
id: ContextId, id: ContextId,
replica_id: ReplicaId, replica_id: ReplicaId,
@ -768,7 +767,6 @@ impl AssistantContext {
} }
} }
#[allow(clippy::too_many_arguments)]
pub fn deserialize( pub fn deserialize(
saved_context: SavedContext, saved_context: SavedContext,
path: PathBuf, path: PathBuf,

2
crates/assistant_context_editor/src/context_editor.rs
View file

@ -535,7 +535,6 @@ impl ContextEditor {
} }
} }
#[allow(clippy::too_many_arguments)]
pub fn run_command( pub fn run_command(
&mut self, &mut self,
command_range: Range<language::Anchor>, command_range: Range<language::Anchor>,
@ -2057,7 +2056,6 @@ impl ContextEditor {
.unwrap_or_else(|| Cow::Borrowed(DEFAULT_TAB_TITLE)) .unwrap_or_else(|| Cow::Borrowed(DEFAULT_TAB_TITLE))
} }
#[allow(clippy::too_many_arguments)]
fn render_patch_block( fn render_patch_block(
&mut self, &mut self,
range: Range<text::Anchor>, range: Range<text::Anchor>,

1
crates/assistant_context_editor/src/slash_command.rs
View file

@ -134,7 +134,6 @@ impl SlashCommandCompletionProvider {
}) })
} }
#[allow(clippy::too_many_arguments)]
fn complete_command_argument( fn complete_command_argument(
&self, &self,
command_name: &str, command_name: &str,

1
crates/assistant_slash_command/src/assistant_slash_command.rs
View file

@ -88,7 +88,6 @@ pub trait SlashCommand: 'static + Send + Sync {
fn accepts_arguments(&self) -> bool { fn accepts_arguments(&self) -> bool {
self.requires_argument() self.requires_argument()
} }
#[allow(clippy::too_many_arguments)]
fn run( fn run(
self: Arc<Self>, self: Arc<Self>,
arguments: &[String], arguments: &[String],

1
crates/buffer_diff/src/buffer_diff.rs
View file

@ -828,7 +828,6 @@ impl BufferDiff {
Some(start..end) Some(start..end)
} }
#[allow(clippy::too_many_arguments)]
pub async fn update_diff( pub async fn update_diff(
this: Entity<BufferDiff>, this: Entity<BufferDiff>,
buffer: text::BufferSnapshot, buffer: text::BufferSnapshot,

1
crates/collab/src/db/queries/messages.rs
View file

@ -229,7 +229,6 @@ impl Database {
} }
/// Creates a new channel message. /// Creates a new channel message.
#[allow(clippy::too_many_arguments)]
pub async fn create_channel_message( pub async fn create_channel_message(
&self, &self,
channel_id: ChannelId, channel_id: ChannelId,

1
crates/collab/src/db/queries/users.rs
View file

@ -122,7 +122,6 @@ impl Database {
.await .await
} }
#[allow(clippy::too_many_arguments)]
pub async fn get_or_create_user_by_github_account_tx( pub async fn get_or_create_user_by_github_account_tx(
&self, &self,
github_login: &str, github_login: &str,

2
crates/collab/src/llm/db/queries/usages.rs
View file

@ -289,7 +289,6 @@ impl LlmDatabase {
.await .await
} }
#[allow(clippy::too_many_arguments)]
pub async fn record_usage( pub async fn record_usage(
&self, &self,
user_id: UserId, user_id: UserId,
@ -554,7 +553,6 @@ impl LlmDatabase {
.await .await
} }
#[allow(clippy::too_many_arguments)]
async fn update_usage_for_measure( async fn update_usage_for_measure(
&self, &self,
user_id: UserId, user_id: UserId,

1
crates/collab/src/llm/token.rs
View file

@ -33,7 +33,6 @@ pub struct LlmTokenClaims {
const LLM_TOKEN_LIFETIME: Duration = Duration::from_secs(60 * 60); const LLM_TOKEN_LIFETIME: Duration = Duration::from_secs(60 * 60);
impl LlmTokenClaims { impl LlmTokenClaims {
#[allow(clippy::too_many_arguments)]
pub fn create( pub fn create(
user: &user::Model, user: &user::Model,
is_staff: bool, is_staff: bool,

2
crates/collab/src/rpc.rs
View file

@ -697,7 +697,6 @@ impl Server {
}) })
} }
#[allow(clippy::too_many_arguments)]
pub fn handle_connection( pub fn handle_connection(
self: &Arc<Self>, self: &Arc<Self>,
connection: Connection, connection: Connection,
@ -1081,7 +1080,6 @@ pub fn routes(server: Arc<Server>) -> Router<(), Body> {
.layer(Extension(server)) .layer(Extension(server))
} }
#[allow(clippy::too_many_arguments)]
pub async fn handle_websocket_request( pub async fn handle_websocket_request(
TypedHeader(ProtocolVersion(protocol_version)): TypedHeader<ProtocolVersion>, TypedHeader(ProtocolVersion(protocol_version)): TypedHeader<ProtocolVersion>,
app_version_header: Option<TypedHeader<AppVersionHeader>>, app_version_header: Option<TypedHeader<AppVersionHeader>>,

1
crates/collab/src/tests/randomized_test_helpers.rs
View file

@ -463,7 +463,6 @@ impl<T: RandomizedTest> TestPlan<T> {
}) })
} }
#[allow(clippy::too_many_arguments)]
async fn apply_server_operation( async fn apply_server_operation(
plan: Arc<Mutex<Self>>, plan: Arc<Mutex<Self>>,
deterministic: BackgroundExecutor, deterministic: BackgroundExecutor,

1
crates/collab_ui/src/collab_panel.rs
View file

@ -869,7 +869,6 @@ impl CollabPanel {
}) })
} }
#[allow(clippy::too_many_arguments)]
fn render_participant_project( fn render_participant_project(
&self, &self,
project_id: u64, project_id: u64,

1
crates/editor/src/display_map.rs
View file

@ -113,7 +113,6 @@ pub struct DisplayMap {
} }
impl DisplayMap { impl DisplayMap {
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
buffer: Entity<MultiBuffer>, buffer: Entity<MultiBuffer>,
font: Font, font: Font,

1
crates/editor/src/display_map/block_map.rs
View file

@ -726,7 +726,6 @@ impl BlockMap {
self.show_excerpt_controls self.show_excerpt_controls
} }
#[allow(clippy::too_many_arguments)]
fn header_and_footer_blocks<'a, R, T>( fn header_and_footer_blocks<'a, R, T>(
show_excerpt_controls: bool, show_excerpt_controls: bool,
excerpt_footer_height: u32, excerpt_footer_height: u32,

7
crates/editor/src/editor.rs
View file

@ -5931,7 +5931,6 @@ impl Editor {
const EDIT_PREDICTION_POPOVER_PADDING_X: Pixels = Pixels(24.); const EDIT_PREDICTION_POPOVER_PADDING_X: Pixels = Pixels(24.);
const EDIT_PREDICTION_POPOVER_PADDING_Y: Pixels = Pixels(2.); const EDIT_PREDICTION_POPOVER_PADDING_Y: Pixels = Pixels(2.);
#[allow(clippy::too_many_arguments)]
fn render_edit_prediction_popover( fn render_edit_prediction_popover(
&mut self, &mut self,
text_bounds: &Bounds<Pixels>, text_bounds: &Bounds<Pixels>,
@ -6043,7 +6042,6 @@ impl Editor {
} }
} }
#[allow(clippy::too_many_arguments)]
fn render_edit_prediction_modifier_jump_popover( fn render_edit_prediction_modifier_jump_popover(
&mut self, &mut self,
text_bounds: &Bounds<Pixels>, text_bounds: &Bounds<Pixels>,
@ -6139,7 +6137,6 @@ impl Editor {
Some((element, origin)) Some((element, origin))
} }
#[allow(clippy::too_many_arguments)]
fn render_edit_prediction_scroll_popover( fn render_edit_prediction_scroll_popover(
&mut self, &mut self,
to_y: impl Fn(Size<Pixels>) -> Pixels, to_y: impl Fn(Size<Pixels>) -> Pixels,
@ -6170,7 +6167,6 @@ impl Editor {
Some((element, origin)) Some((element, origin))
} }
#[allow(clippy::too_many_arguments)]
fn render_edit_prediction_eager_jump_popover( fn render_edit_prediction_eager_jump_popover(
&mut self, &mut self,
text_bounds: &Bounds<Pixels>, text_bounds: &Bounds<Pixels>,
@ -6240,7 +6236,6 @@ impl Editor {
} }
} }
#[allow(clippy::too_many_arguments)]
fn render_edit_prediction_end_of_line_popover( fn render_edit_prediction_end_of_line_popover(
self: &mut Editor, self: &mut Editor,
label: &'static str, label: &'static str,
@ -6299,7 +6294,6 @@ impl Editor {
Some((element, origin)) Some((element, origin))
} }
#[allow(clippy::too_many_arguments)]
fn render_edit_prediction_diff_popover( fn render_edit_prediction_diff_popover(
self: &Editor, self: &Editor,
text_bounds: &Bounds<Pixels>, text_bounds: &Bounds<Pixels>,
@ -6607,7 +6601,6 @@ impl Editor {
editor_bg_color.blend(accent_color.opacity(0.6)) editor_bg_color.blend(accent_color.opacity(0.6))
} }
#[allow(clippy::too_many_arguments)]
fn render_edit_prediction_cursor_popover( fn render_edit_prediction_cursor_popover(
&self, &self,
min_width: Pixels, min_width: Pixels,

30
crates/editor/src/element.rs
View file

@ -958,7 +958,6 @@ impl EditorElement {
cx.notify() cx.notify()
} }
#[allow(clippy::too_many_arguments)]
fn layout_selections( fn layout_selections(
&self, &self,
start_anchor: Anchor, start_anchor: Anchor,
@ -1130,7 +1129,6 @@ impl EditorElement {
cursors cursors
} }
#[allow(clippy::too_many_arguments)]
fn layout_visible_cursors( fn layout_visible_cursors(
&self, &self,
snapshot: &EditorSnapshot, snapshot: &EditorSnapshot,
@ -1484,7 +1482,6 @@ impl EditorElement {
axis_pair(horizontal_scrollbar, vertical_scrollbar) axis_pair(horizontal_scrollbar, vertical_scrollbar)
} }
#[allow(clippy::too_many_arguments)]
fn prepaint_crease_toggles( fn prepaint_crease_toggles(
&self, &self,
crease_toggles: &mut [Option<AnyElement>], crease_toggles: &mut [Option<AnyElement>],
@ -1519,7 +1516,6 @@ impl EditorElement {
} }
} }
#[allow(clippy::too_many_arguments)]
fn prepaint_crease_trailers( fn prepaint_crease_trailers(
&self, &self,
trailers: Vec<Option<AnyElement>>, trailers: Vec<Option<AnyElement>>,
@ -1596,7 +1592,6 @@ impl EditorElement {
display_hunks display_hunks
} }
#[allow(clippy::too_many_arguments)]
fn layout_inline_diagnostics( fn layout_inline_diagnostics(
&self, &self,
line_layouts: &[LineWithInvisibles], line_layouts: &[LineWithInvisibles],
@ -1747,7 +1742,6 @@ impl EditorElement {
elements elements
} }
#[allow(clippy::too_many_arguments)]
fn layout_inline_blame( fn layout_inline_blame(
&self, &self,
display_row: DisplayRow, display_row: DisplayRow,
@ -1827,7 +1821,6 @@ impl EditorElement {
Some(element) Some(element)
} }
#[allow(clippy::too_many_arguments)]
fn layout_blame_entries( fn layout_blame_entries(
&self, &self,
buffer_rows: &[RowInfo], buffer_rows: &[RowInfo],
@ -1896,7 +1889,6 @@ impl EditorElement {
Some(shaped_lines) Some(shaped_lines)
} }
#[allow(clippy::too_many_arguments)]
fn layout_indent_guides( fn layout_indent_guides(
&self, &self,
content_origin: gpui::Point<Pixels>, content_origin: gpui::Point<Pixels>,
@ -2014,7 +2006,6 @@ impl EditorElement {
(offset_y, length) (offset_y, length)
} }
#[allow(clippy::too_many_arguments)]
fn layout_run_indicators( fn layout_run_indicators(
&self, &self,
line_height: Pixels, line_height: Pixels,
@ -2108,7 +2099,6 @@ impl EditorElement {
}) })
} }
#[allow(clippy::too_many_arguments)]
fn layout_code_actions_indicator( fn layout_code_actions_indicator(
&self, &self,
line_height: Pixels, line_height: Pixels,
@ -2207,7 +2197,6 @@ impl EditorElement {
relative_rows relative_rows
} }
#[allow(clippy::too_many_arguments)]
fn layout_line_numbers( fn layout_line_numbers(
&self, &self,
gutter_hitbox: Option<&Hitbox>, gutter_hitbox: Option<&Hitbox>,
@ -2423,7 +2412,6 @@ impl EditorElement {
} }
} }
#[allow(clippy::too_many_arguments)]
fn prepaint_lines( fn prepaint_lines(
&self, &self,
start_row: DisplayRow, start_row: DisplayRow,
@ -2450,7 +2438,6 @@ impl EditorElement {
line_elements line_elements
} }
#[allow(clippy::too_many_arguments)]
fn render_block( fn render_block(
&self, &self,
block: &Block, block: &Block,
@ -2950,7 +2937,6 @@ impl EditorElement {
})) }))
} }
#[allow(clippy::too_many_arguments)]
fn render_blocks( fn render_blocks(
&self, &self,
rows: Range<DisplayRow>, rows: Range<DisplayRow>,
@ -3135,7 +3121,6 @@ impl EditorElement {
/// Returns true if any of the blocks changed size since the previous frame. This will trigger /// Returns true if any of the blocks changed size since the previous frame. This will trigger
/// a restart of rendering for the editor based on the new sizes. /// a restart of rendering for the editor based on the new sizes.
#[allow(clippy::too_many_arguments)]
fn layout_blocks( fn layout_blocks(
&self, &self,
blocks: &mut Vec<BlockLayout>, blocks: &mut Vec<BlockLayout>,
@ -3179,7 +3164,6 @@ impl EditorElement {
} }
} }
#[allow(clippy::too_many_arguments)]
fn layout_sticky_buffer_header( fn layout_sticky_buffer_header(
&self, &self,
StickyHeaderExcerpt { StickyHeaderExcerpt {
@ -3254,7 +3238,6 @@ impl EditorElement {
header header
} }
#[allow(clippy::too_many_arguments)]
fn layout_cursor_popovers( fn layout_cursor_popovers(
&self, &self,
line_height: Pixels, line_height: Pixels,
@ -3443,7 +3426,6 @@ impl EditorElement {
); );
} }
#[allow(clippy::too_many_arguments)]
fn layout_gutter_menu( fn layout_gutter_menu(
&self, &self,
line_height: Pixels, line_height: Pixels,
@ -3496,7 +3478,6 @@ impl EditorElement {
); );
} }
#[allow(clippy::too_many_arguments)]
fn layout_popovers_above_or_below_line( fn layout_popovers_above_or_below_line(
&self, &self,
target_position: gpui::Point<Pixels>, target_position: gpui::Point<Pixels>,
@ -3610,7 +3591,6 @@ impl EditorElement {
}) })
} }
#[allow(clippy::too_many_arguments)]
fn layout_context_menu_aside( fn layout_context_menu_aside(
&self, &self,
y_flipped: bool, y_flipped: bool,
@ -3806,7 +3786,6 @@ impl EditorElement {
}) })
} }
#[allow(clippy::too_many_arguments)]
fn layout_hover_popovers( fn layout_hover_popovers(
&self, &self,
snapshot: &EditorSnapshot, snapshot: &EditorSnapshot,
@ -3923,7 +3902,6 @@ impl EditorElement {
} }
} }
#[allow(clippy::too_many_arguments)]
fn layout_diff_hunk_controls( fn layout_diff_hunk_controls(
&self, &self,
row_range: Range<DisplayRow>, row_range: Range<DisplayRow>,
@ -4008,7 +3986,6 @@ impl EditorElement {
controls controls
} }
#[allow(clippy::too_many_arguments)]
fn layout_signature_help( fn layout_signature_help(
&self, &self,
hitbox: &Hitbox, hitbox: &Hitbox,
@ -5304,7 +5281,6 @@ impl EditorElement {
}); });
} }
#[allow(clippy::too_many_arguments)]
fn paint_highlighted_range( fn paint_highlighted_range(
&self, &self,
range: Range<DisplayPoint>, range: Range<DisplayPoint>,
@ -5730,7 +5706,6 @@ impl AcceptEditPredictionBinding {
} }
} }
#[allow(clippy::too_many_arguments)]
fn prepaint_gutter_button( fn prepaint_gutter_button(
button: IconButton, button: IconButton,
row: DisplayRow, row: DisplayRow,
@ -5981,7 +5956,6 @@ impl fmt::Debug for LineFragment {
} }
impl LineWithInvisibles { impl LineWithInvisibles {
#[allow(clippy::too_many_arguments)]
fn from_chunks<'a>( fn from_chunks<'a>(
chunks: impl Iterator<Item = HighlightedChunk<'a>>, chunks: impl Iterator<Item = HighlightedChunk<'a>>,
editor_style: &EditorStyle, editor_style: &EditorStyle,
@ -6186,7 +6160,6 @@ impl LineWithInvisibles {
layouts layouts
} }
#[allow(clippy::too_many_arguments)]
fn prepaint( fn prepaint(
&mut self, &mut self,
line_height: Pixels, line_height: Pixels,
@ -6221,7 +6194,6 @@ impl LineWithInvisibles {
} }
} }
#[allow(clippy::too_many_arguments)]
fn draw( fn draw(
&self, &self,
layout: &EditorLayout, layout: &EditorLayout,
@ -6265,7 +6237,6 @@ impl LineWithInvisibles {
); );
} }
#[allow(clippy::too_many_arguments)]
fn draw_invisibles( fn draw_invisibles(
&self, &self,
selection_ranges: &[Range<DisplayPoint>], selection_ranges: &[Range<DisplayPoint>],
@ -7659,7 +7630,6 @@ struct ScrollbarRangeData {
} }
impl ScrollbarRangeData { impl ScrollbarRangeData {
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
scrollbar_bounds: Bounds<Pixels>, scrollbar_bounds: Bounds<Pixels>,
letter_size: Size<Pixels>, letter_size: Size<Pixels>,

2
crates/editor/src/scroll.rs
View file

@ -223,7 +223,6 @@ impl ScrollManager {
self.anchor.scroll_position(snapshot) self.anchor.scroll_position(snapshot)
} }
#[allow(clippy::too_many_arguments)]
fn set_scroll_position( fn set_scroll_position(
&mut self, &mut self,
scroll_position: gpui::Point<f32>, scroll_position: gpui::Point<f32>,
@ -298,7 +297,6 @@ impl ScrollManager {
); );
} }
#[allow(clippy::too_many_arguments)]
fn set_anchor( fn set_anchor(
&mut self, &mut self,
anchor: ScrollAnchor, anchor: ScrollAnchor,

1
crates/evals/src/eval.rs
View file

@ -399,7 +399,6 @@ async fn run_evaluation(
} }
} }
#[allow(clippy::too_many_arguments)]
async fn run_eval_project( async fn run_eval_project(
evaluation_project: EvaluationProject, evaluation_project: EvaluationProject,
user_store: &Entity<UserStore>, user_store: &Entity<UserStore>,

1
crates/extension_api/src/extension_api.rs
View file

@ -195,7 +195,6 @@ static mut EXTENSION: Option<Box<dyn Extension>> = None;
pub static ZED_API_VERSION: [u8; 6] = *include_bytes!(concat!(env!("OUT_DIR"), "/version_bytes")); pub static ZED_API_VERSION: [u8; 6] = *include_bytes!(concat!(env!("OUT_DIR"), "/version_bytes"));
mod wit { mod wit {
#![allow(clippy::too_many_arguments, clippy::missing_safety_doc)]
wit_bindgen::generate!({ wit_bindgen::generate!({
skip: ["init-extension"], skip: ["init-extension"],

1
crates/extension_host/src/extension_host.rs
View file

@ -218,7 +218,6 @@ impl ExtensionStore {
cx.global::<GlobalExtensionStore>().0.clone() cx.global::<GlobalExtensionStore>().0.clone()
} }
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
extensions_dir: PathBuf, extensions_dir: PathBuf,
build_dir: Option<PathBuf>, build_dir: Option<PathBuf>,

1
crates/file_finder/src/file_finder.rs
View file

@ -653,7 +653,6 @@ impl FileSearchQuery {
} }
impl FileFinderDelegate { impl FileFinderDelegate {
#[allow(clippy::too_many_arguments)]
fn new( fn new(
file_finder: WeakEntity<FileFinder>, file_finder: WeakEntity<FileFinder>,
workspace: WeakEntity<Workspace>, workspace: WeakEntity<Workspace>,

1
crates/fuzzy/src/matcher.rs
View file

@ -170,7 +170,6 @@ impl<'a> Matcher<'a> {
score score
} }
#[allow(clippy::too_many_arguments)]
fn recursive_score_match( fn recursive_score_match(
&mut self, &mut self,
path: &[char], path: &[char],

1
crates/gpui/src/platform/linux/wayland/window.rs
View file

@ -115,7 +115,6 @@ pub struct WaylandWindowStatePtr {
} }
impl WaylandWindowState { impl WaylandWindowState {
#[allow(clippy::too_many_arguments)]
pub(crate) fn new( pub(crate) fn new(
handle: AnyWindowHandle, handle: AnyWindowHandle,
surface: wl_surface::WlSurface, surface: wl_surface::WlSurface,

2
crates/gpui/src/platform/linux/x11/window.rs
View file

@ -353,7 +353,6 @@ where
} }
impl X11WindowState { impl X11WindowState {
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
handle: AnyWindowHandle, handle: AnyWindowHandle,
client: X11ClientStatePtr, client: X11ClientStatePtr,
@ -712,7 +711,6 @@ enum WmHintPropertyState {
} }
impl X11Window { impl X11Window {
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
handle: AnyWindowHandle, handle: AnyWindowHandle,
client: X11ClientStatePtr, client: X11ClientStatePtr,

1
crates/gpui/src/text_system/line.rs
View file

@ -132,7 +132,6 @@ impl WrappedLine {
} }
} }
#[allow(clippy::too_many_arguments)]
fn paint_line( fn paint_line(
origin: Point<Pixels>, origin: Point<Pixels>,
layout: &LineLayout, layout: &LineLayout,

1
crates/language/src/syntax_map.rs
View file

@ -1250,7 +1250,6 @@ fn parse_text(
}) })
} }
#[allow(clippy::too_many_arguments)]
fn get_injections( fn get_injections(
config: &InjectionConfig, config: &InjectionConfig,
text: &BufferSnapshot, text: &BufferSnapshot,

2
crates/lsp/src/lsp.rs
View file

@ -301,7 +301,6 @@ pub struct AdapterServerCapabilities {
impl LanguageServer { impl LanguageServer {
/// Starts a language server process. /// Starts a language server process.
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
stderr_capture: Arc<Mutex<Option<String>>>, stderr_capture: Arc<Mutex<Option<String>>>,
server_id: LanguageServerId, server_id: LanguageServerId,
@ -372,7 +371,6 @@ impl LanguageServer {
Ok(server) Ok(server)
} }
#[allow(clippy::too_many_arguments)]
fn new_internal<Stdin, Stdout, Stderr, F>( fn new_internal<Stdin, Stdout, Stderr, F>(
server_id: LanguageServerId, server_id: LanguageServerId,
server_name: LanguageServerName, server_name: LanguageServerName,

1
crates/multi_buffer/src/multi_buffer.rs
View file

@ -2982,7 +2982,6 @@ impl MultiBuffer {
snapshot.check_invariants(); snapshot.check_invariants();
} }
#[allow(clippy::too_many_arguments)]
fn recompute_diff_transforms_for_edit( fn recompute_diff_transforms_for_edit(
&self, &self,
edit: &Edit<TypedOffset<Excerpt>>, edit: &Edit<TypedOffset<Excerpt>>,

5
crates/outline_panel/src/outline_panel.rs
View file

@ -2360,7 +2360,6 @@ impl OutlinePanel {
) )
} }
#[allow(clippy::too_many_arguments)]
fn render_search_match( fn render_search_match(
&mut self, &mut self,
multi_buffer_snapshot: Option<&MultiBufferSnapshot>, multi_buffer_snapshot: Option<&MultiBufferSnapshot>,
@ -2452,7 +2451,6 @@ impl OutlinePanel {
)) ))
} }
#[allow(clippy::too_many_arguments)]
fn entry_element( fn entry_element(
&self, &self,
rendered_entry: PanelEntry, rendered_entry: PanelEntry,
@ -3836,7 +3834,6 @@ impl OutlinePanel {
}) })
} }
#[allow(clippy::too_many_arguments)]
fn push_entry( fn push_entry(
&self, &self,
state: &mut GenerationState, state: &mut GenerationState,
@ -4054,7 +4051,6 @@ impl OutlinePanel {
update_cached_entries update_cached_entries
} }
#[allow(clippy::too_many_arguments)]
fn add_excerpt_entries( fn add_excerpt_entries(
&self, &self,
state: &mut GenerationState, state: &mut GenerationState,
@ -4113,7 +4109,6 @@ impl OutlinePanel {
} }
} }
#[allow(clippy::too_many_arguments)]
fn add_search_entries( fn add_search_entries(
&mut self, &mut self,
state: &mut GenerationState, state: &mut GenerationState,

6
crates/project/src/lsp_store.rs
View file

@ -1245,7 +1245,6 @@ impl LocalLspStore {
Ok(project_transaction) Ok(project_transaction)
} }
#[allow(clippy::too_many_arguments)]
async fn execute_formatters( async fn execute_formatters(
lsp_store: WeakEntity<LspStore>, lsp_store: WeakEntity<LspStore>,
formatters: &[Formatter], formatters: &[Formatter],
@ -1495,7 +1494,6 @@ impl LocalLspStore {
} }
} }
#[allow(clippy::too_many_arguments)]
async fn format_via_lsp( async fn format_via_lsp(
this: &WeakEntity<LspStore>, this: &WeakEntity<LspStore>,
buffer: &Entity<Buffer>, buffer: &Entity<Buffer>,
@ -2999,7 +2997,6 @@ impl LspStore {
} }
} }
#[allow(clippy::too_many_arguments)]
pub fn new_local( pub fn new_local(
buffer_store: Entity<BufferStore>, buffer_store: Entity<BufferStore>,
worktree_store: Entity<WorktreeStore>, worktree_store: Entity<WorktreeStore>,
@ -3093,7 +3090,6 @@ impl LspStore {
}) })
} }
#[allow(clippy::too_many_arguments)]
pub(super) fn new_remote( pub(super) fn new_remote(
buffer_store: Entity<BufferStore>, buffer_store: Entity<BufferStore>,
worktree_store: Entity<WorktreeStore>, worktree_store: Entity<WorktreeStore>,
@ -4619,7 +4615,6 @@ impl LspStore {
Ok(()) Ok(())
} }
#[allow(clippy::too_many_arguments)]
async fn resolve_completion_remote( async fn resolve_completion_remote(
project_id: u64, project_id: u64,
server_id: LanguageServerId, server_id: LanguageServerId,
@ -7736,7 +7731,6 @@ impl LspStore {
Ok(()) Ok(())
} }
#[allow(clippy::too_many_arguments)]
fn insert_newly_running_language_server( fn insert_newly_running_language_server(
&mut self, &mut self,
adapter: Arc<CachedLspAdapter>, adapter: Arc<CachedLspAdapter>,

1
crates/project/src/project.rs
View file

@ -1118,7 +1118,6 @@ impl Project {
.await .await
} }
#[allow(clippy::too_many_arguments)]
async fn from_join_project_response( async fn from_join_project_response(
response: TypedEnvelope<proto::JoinProjectResponse>, response: TypedEnvelope<proto::JoinProjectResponse>,
subscriptions: [EntitySubscription; 5], subscriptions: [EntitySubscription; 5],

1
crates/remote/src/ssh_session.rs
View file

@ -1280,7 +1280,6 @@ impl From<SshRemoteClient> for AnyProtoClient {
#[async_trait(?Send)] #[async_trait(?Send)]
trait RemoteConnection: Send + Sync { trait RemoteConnection: Send + Sync {
#[allow(clippy::too_many_arguments)]
fn start_proxy( fn start_proxy(
&self, &self,
unique_identifier: String, unique_identifier: String,

1
crates/rich_text/src/rich_text.rs
View file

@ -175,7 +175,6 @@ impl RichText {
} }
} }
#[allow(clippy::too_many_arguments)]
pub fn render_markdown_mut( pub fn render_markdown_mut(
block: &str, block: &str,
mut mentions: &[Mention], mut mentions: &[Mention],

1
crates/semantic_index/src/worktree_index.rs
View file

@ -116,7 +116,6 @@ impl WorktreeIndex {
}) })
} }
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
worktree: Entity<Worktree>, worktree: Entity<Worktree>,
db_connection: heed::Env, db_connection: heed::Env,

1
crates/terminal/src/terminal.rs
View file

@ -325,7 +325,6 @@ pub struct TerminalBuilder {
} }
impl TerminalBuilder { impl TerminalBuilder {
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
working_directory: Option<PathBuf>, working_directory: Option<PathBuf>,
python_venv_directory: Option<PathBuf>, python_venv_directory: Option<PathBuf>,

1
crates/terminal_view/src/terminal_element.rs
View file

@ -171,7 +171,6 @@ impl InteractiveElement for TerminalElement {
impl StatefulInteractiveElement for TerminalElement {} impl StatefulInteractiveElement for TerminalElement {}
impl TerminalElement { impl TerminalElement {
#[allow(clippy::too_many_arguments)]
pub fn new( pub fn new(
terminal: Entity<Terminal>, terminal: Entity<Terminal>,
terminal_view: Entity<TerminalView>, terminal_view: Entity<TerminalView>,

1
crates/title_bar/src/collab.rs
View file

@ -191,7 +191,6 @@ impl TitleBar {
) )
} }
#[allow(clippy::too_many_arguments)]
fn render_collaborator( fn render_collaborator(
&self, &self,
user: &Arc<User>, user: &Arc<User>,

2
crates/toolchain_selector/src/toolchain_selector.rs
View file

@ -85,7 +85,6 @@ impl ToolchainSelector {
Some(()) Some(())
} }
#[allow(clippy::too_many_arguments)]
fn new( fn new(
workspace: WeakEntity<Workspace>, workspace: WeakEntity<Workspace>,
project: Entity<Project>, project: Entity<Project>,
@ -143,7 +142,6 @@ pub struct ToolchainSelectorDelegate {
} }
impl ToolchainSelectorDelegate { impl ToolchainSelectorDelegate {
#[allow(clippy::too_many_arguments)]
fn new( fn new(
active_toolchain: Option<Toolchain>, active_toolchain: Option<Toolchain>,
toolchain_selector: WeakEntity<ToolchainSelector>, toolchain_selector: WeakEntity<ToolchainSelector>,

2
crates/workspace/src/pane.rs
View file

@ -843,7 +843,6 @@ impl Pane {
} }
} }
#[allow(clippy::too_many_arguments)]
pub(crate) fn open_item( pub(crate) fn open_item(
&mut self, &mut self,
project_entry_id: Option<ProjectEntryId>, project_entry_id: Option<ProjectEntryId>,
@ -928,7 +927,6 @@ impl Pane {
} }
} }
#[allow(clippy::too_many_arguments)]
pub fn add_item_inner( pub fn add_item_inner(
&mut self, &mut self,
item: Box<dyn ItemHandle>, item: Box<dyn ItemHandle>,

5
crates/workspace/src/pane_group.rs
View file

@ -122,7 +122,6 @@ impl PaneGroup {
}; };
} }
#[allow(clippy::too_many_arguments)]
pub fn render( pub fn render(
&self, &self,
project: &Entity<Project>, project: &Entity<Project>,
@ -221,7 +220,6 @@ impl Member {
} }
} }
#[allow(clippy::too_many_arguments)]
pub fn render( pub fn render(
&self, &self,
project: &Entity<Project>, project: &Entity<Project>,
@ -671,7 +669,6 @@ impl PaneAxis {
None None
} }
#[allow(clippy::too_many_arguments)]
fn render( fn render(
&self, &self,
project: &Entity<Project>, project: &Entity<Project>,
@ -875,7 +872,6 @@ mod element {
self self
} }
#[allow(clippy::too_many_arguments)]
fn compute_resize( fn compute_resize(
flexes: &Arc<Mutex<Vec<f32>>>, flexes: &Arc<Mutex<Vec<f32>>>,
e: &MouseMoveEvent, e: &MouseMoveEvent,
@ -965,7 +961,6 @@ mod element {
window.refresh(); window.refresh();
} }
#[allow(clippy::too_many_arguments)]
fn layout_handle( fn layout_handle(
axis: Axis, axis: Axis,
pane_bounds: Bounds<Pixels>, pane_bounds: Bounds<Pixels>,

2
crates/workspace/src/workspace.rs
View file

@ -2732,7 +2732,6 @@ impl Workspace {
) )
} }
#[allow(clippy::too_many_arguments)]
pub fn add_item( pub fn add_item(
&mut self, &mut self,
pane: Entity<Pane>, pane: Entity<Pane>,
@ -2830,7 +2829,6 @@ impl Workspace {
self.open_path_preview(path, pane, focus_item, false, true, window, cx) self.open_path_preview(path, pane, focus_item, false, true, window, cx)
} }
#[allow(clippy::too_many_arguments)]
pub fn open_path_preview( pub fn open_path_preview(
&mut self, &mut self,
path: impl Into<ProjectPath>, path: impl Into<ProjectPath>,

2
crates/zeta/src/zeta.rs
View file

@ -353,7 +353,6 @@ impl Zeta {
} }
} }
#[allow(clippy::too_many_arguments)]
fn request_completion_impl<F, R>( fn request_completion_impl<F, R>(
&mut self, &mut self,
workspace: Option<Entity<Workspace>>, workspace: Option<Entity<Workspace>>,
@ -791,7 +790,6 @@ and then another
} }
} }
#[allow(clippy::too_many_arguments)]
fn process_completion_response( fn process_completion_response(
prediction_response: PredictEditsResponse, prediction_response: PredictEditsResponse,
buffer: Entity<Buffer>, buffer: Entity<Buffer>,