Allow too many arguments (#26375)

This is nearly half of our #allows, and seems like something we happily break whenever we need Release Notes: - N/A
2025-03-10 13:38:30 -06:00 · 2025-03-10 13:38:30 -06:00 · 63091459d8
commit 63091459d8
parent 659fae70f8
48 changed files with 4 additions and 111 deletions
--- a/Cargo.toml
+++ b/Cargo.toml
@ -751,5 +751,9 @@ new_ret_no_self = { level = "allow" }
 should_implement_trait = { level = "allow" }
 let_underscore_future = "allow"

+# in Rust it can be very tedious to reduce argument count without
+# running afoul of the borrow checker.
+too_many_arguments = "allow"
+
 [workspace.metadata.cargo-machete]
 ignored = ["bindgen", "cbindgen", "prost_build", "serde", "component", "linkme"]
--- a/crates/assistant/src/inline_assistant.rs
+++ b/crates/assistant/src/inline_assistant.rs
@ -386,7 +386,6 @@ impl InlineAssistant {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn suggest_assist(
        &mut self,
        editor: &Entity<Editor>,
@ -1674,7 +1673,6 @@ impl Focusable for PromptEditor {
 impl PromptEditor {
    const MAX_LINES: u8 = 8;

-    #[allow(clippy::too_many_arguments)]
    fn new(
        id: InlineAssistId,
        gutter_dimensions: Arc<Mutex<GutterDimensions>>,
@ -2333,7 +2331,6 @@ struct InlineAssist {
 }

 impl InlineAssist {
-    #[allow(clippy::too_many_arguments)]
    fn new(
        assist_id: InlineAssistId,
        group_id: InlineAssistGroupId,
--- a/crates/assistant/src/terminal_inline_assistant.rs
+++ b/crates/assistant/src/terminal_inline_assistant.rs
@ -702,7 +702,6 @@ impl Focusable for PromptEditor {
 impl PromptEditor {
    const MAX_LINES: u8 = 8;

-    #[allow(clippy::too_many_arguments)]
    fn new(
        id: TerminalInlineAssistId,
        prompt_history: VecDeque<String>,
--- a/crates/assistant2/src/context_strip.rs
+++ b/crates/assistant2/src/context_strip.rs
@ -36,7 +36,6 @@ pub struct ContextStrip {
 }

 impl ContextStrip {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        context_store: Entity<ContextStore>,
        workspace: WeakEntity<Workspace>,
--- a/crates/assistant2/src/inline_assistant.rs
+++ b/crates/assistant2/src/inline_assistant.rs
@ -480,7 +480,6 @@ impl InlineAssistant {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn suggest_assist(
        &mut self,
        editor: &Entity<Editor>,
@ -1451,7 +1450,6 @@ struct InlineAssistScrollLock {
 }

 impl EditorInlineAssists {
-    #[allow(clippy::too_many_arguments)]
    fn new(editor: &Entity<Editor>, window: &mut Window, cx: &mut App) -> Self {
        let (highlight_updates_tx, mut highlight_updates_rx) = async_watch::channel(());
        Self {
@ -1563,7 +1561,6 @@ pub struct InlineAssist {
 }

 impl InlineAssist {
-    #[allow(clippy::too_many_arguments)]
    fn new(
        assist_id: InlineAssistId,
        group_id: InlineAssistGroupId,
--- a/crates/assistant2/src/inline_prompt_editor.rs
+++ b/crates/assistant2/src/inline_prompt_editor.rs
@ -816,7 +816,6 @@ impl InlineAssistId {
 }

 impl PromptEditor<BufferCodegen> {
-    #[allow(clippy::too_many_arguments)]
    pub fn new_buffer(
        id: InlineAssistId,
        gutter_dimensions: Arc<Mutex<GutterDimensions>>,
@ -976,7 +975,6 @@ impl TerminalInlineAssistId {
 }

 impl PromptEditor<TerminalCodegen> {
-    #[allow(clippy::too_many_arguments)]
    pub fn new_terminal(
        id: TerminalInlineAssistId,
        prompt_history: VecDeque<String>,
--- a/crates/assistant_context_editor/src/context.rs
+++ b/crates/assistant_context_editor/src/context.rs
@ -647,7 +647,6 @@ impl AssistantContext {
        )
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        id: ContextId,
        replica_id: ReplicaId,
@ -768,7 +767,6 @@ impl AssistantContext {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn deserialize(
        saved_context: SavedContext,
        path: PathBuf,
--- a/crates/assistant_context_editor/src/context_editor.rs
+++ b/crates/assistant_context_editor/src/context_editor.rs
@ -535,7 +535,6 @@ impl ContextEditor {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn run_command(
        &mut self,
        command_range: Range<language::Anchor>,
@ -2057,7 +2056,6 @@ impl ContextEditor {
            .unwrap_or_else(|| Cow::Borrowed(DEFAULT_TAB_TITLE))
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_patch_block(
        &mut self,
        range: Range<text::Anchor>,
--- a/crates/assistant_context_editor/src/slash_command.rs
+++ b/crates/assistant_context_editor/src/slash_command.rs
@ -134,7 +134,6 @@ impl SlashCommandCompletionProvider {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    fn complete_command_argument(
        &self,
        command_name: &str,
--- a/crates/assistant_slash_command/src/assistant_slash_command.rs
+++ b/crates/assistant_slash_command/src/assistant_slash_command.rs
@ -88,7 +88,6 @@ pub trait SlashCommand: 'static + Send + Sync {
    fn accepts_arguments(&self) -> bool {
        self.requires_argument()
    }
-    #[allow(clippy::too_many_arguments)]
    fn run(
        self: Arc<Self>,
        arguments: &[String],
--- a/crates/buffer_diff/src/buffer_diff.rs
+++ b/crates/buffer_diff/src/buffer_diff.rs
@ -828,7 +828,6 @@ impl BufferDiff {
        Some(start..end)
    }

-    #[allow(clippy::too_many_arguments)]
    pub async fn update_diff(
        this: Entity<BufferDiff>,
        buffer: text::BufferSnapshot,
--- a/crates/collab/src/db/queries/messages.rs
+++ b/crates/collab/src/db/queries/messages.rs
@ -229,7 +229,6 @@ impl Database {
    }

    /// Creates a new channel message.
-    #[allow(clippy::too_many_arguments)]
    pub async fn create_channel_message(
        &self,
        channel_id: ChannelId,
--- a/crates/collab/src/db/queries/users.rs
+++ b/crates/collab/src/db/queries/users.rs
@ -122,7 +122,6 @@ impl Database {
        .await
    }

-    #[allow(clippy::too_many_arguments)]
    pub async fn get_or_create_user_by_github_account_tx(
        &self,
        github_login: &str,
--- a/crates/collab/src/llm/db/queries/usages.rs
+++ b/crates/collab/src/llm/db/queries/usages.rs
@ -289,7 +289,6 @@ impl LlmDatabase {
        .await
    }

-    #[allow(clippy::too_many_arguments)]
    pub async fn record_usage(
        &self,
        user_id: UserId,
@ -554,7 +553,6 @@ impl LlmDatabase {
        .await
    }

-    #[allow(clippy::too_many_arguments)]
    async fn update_usage_for_measure(
        &self,
        user_id: UserId,
--- a/crates/collab/src/llm/token.rs
+++ b/crates/collab/src/llm/token.rs
@ -33,7 +33,6 @@ pub struct LlmTokenClaims {
 const LLM_TOKEN_LIFETIME: Duration = Duration::from_secs(60 * 60);

 impl LlmTokenClaims {
-    #[allow(clippy::too_many_arguments)]
    pub fn create(
        user: &user::Model,
        is_staff: bool,
--- a/crates/collab/src/rpc.rs
+++ b/crates/collab/src/rpc.rs
@ -697,7 +697,6 @@ impl Server {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn handle_connection(
        self: &Arc<Self>,
        connection: Connection,
@ -1081,7 +1080,6 @@ pub fn routes(server: Arc<Server>) -> Router<(), Body> {
        .layer(Extension(server))
 }

-#[allow(clippy::too_many_arguments)]
 pub async fn handle_websocket_request(
    TypedHeader(ProtocolVersion(protocol_version)): TypedHeader<ProtocolVersion>,
    app_version_header: Option<TypedHeader<AppVersionHeader>>,
--- a/crates/collab/src/tests/randomized_test_helpers.rs
+++ b/crates/collab/src/tests/randomized_test_helpers.rs
@ -463,7 +463,6 @@ impl<T: RandomizedTest> TestPlan<T> {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    async fn apply_server_operation(
        plan: Arc<Mutex<Self>>,
        deterministic: BackgroundExecutor,
--- a/crates/collab_ui/src/collab_panel.rs
+++ b/crates/collab_ui/src/collab_panel.rs
@ -869,7 +869,6 @@ impl CollabPanel {
            })
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_participant_project(
        &self,
        project_id: u64,
--- a/crates/editor/src/display_map.rs
+++ b/crates/editor/src/display_map.rs
@ -113,7 +113,6 @@ pub struct DisplayMap {
 }

 impl DisplayMap {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        buffer: Entity<MultiBuffer>,
        font: Font,
--- a/crates/editor/src/display_map/block_map.rs
+++ b/crates/editor/src/display_map/block_map.rs
@ -726,7 +726,6 @@ impl BlockMap {
        self.show_excerpt_controls
    }

-    #[allow(clippy::too_many_arguments)]
    fn header_and_footer_blocks<'a, R, T>(
        show_excerpt_controls: bool,
        excerpt_footer_height: u32,
--- a/crates/editor/src/editor.rs
+++ b/crates/editor/src/editor.rs
@ -5931,7 +5931,6 @@ impl Editor {
    const EDIT_PREDICTION_POPOVER_PADDING_X: Pixels = Pixels(24.);
    const EDIT_PREDICTION_POPOVER_PADDING_Y: Pixels = Pixels(2.);

-    #[allow(clippy::too_many_arguments)]
    fn render_edit_prediction_popover(
        &mut self,
        text_bounds: &Bounds<Pixels>,
@ -6043,7 +6042,6 @@ impl Editor {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_edit_prediction_modifier_jump_popover(
        &mut self,
        text_bounds: &Bounds<Pixels>,
@ -6139,7 +6137,6 @@ impl Editor {
        Some((element, origin))
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_edit_prediction_scroll_popover(
        &mut self,
        to_y: impl Fn(Size<Pixels>) -> Pixels,
@ -6170,7 +6167,6 @@ impl Editor {
        Some((element, origin))
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_edit_prediction_eager_jump_popover(
        &mut self,
        text_bounds: &Bounds<Pixels>,
@ -6240,7 +6236,6 @@ impl Editor {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_edit_prediction_end_of_line_popover(
        self: &mut Editor,
        label: &'static str,
@ -6299,7 +6294,6 @@ impl Editor {
        Some((element, origin))
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_edit_prediction_diff_popover(
        self: &Editor,
        text_bounds: &Bounds<Pixels>,
@ -6607,7 +6601,6 @@ impl Editor {
        editor_bg_color.blend(accent_color.opacity(0.6))
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_edit_prediction_cursor_popover(
        &self,
        min_width: Pixels,
--- a/crates/editor/src/element.rs
+++ b/crates/editor/src/element.rs
@ -958,7 +958,6 @@ impl EditorElement {
        cx.notify()
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_selections(
        &self,
        start_anchor: Anchor,
@ -1130,7 +1129,6 @@ impl EditorElement {
        cursors
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_visible_cursors(
        &self,
        snapshot: &EditorSnapshot,
@ -1484,7 +1482,6 @@ impl EditorElement {
        axis_pair(horizontal_scrollbar, vertical_scrollbar)
    }

-    #[allow(clippy::too_many_arguments)]
    fn prepaint_crease_toggles(
        &self,
        crease_toggles: &mut [Option<AnyElement>],
@ -1519,7 +1516,6 @@ impl EditorElement {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn prepaint_crease_trailers(
        &self,
        trailers: Vec<Option<AnyElement>>,
@ -1596,7 +1592,6 @@ impl EditorElement {
        display_hunks
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_inline_diagnostics(
        &self,
        line_layouts: &[LineWithInvisibles],
@ -1747,7 +1742,6 @@ impl EditorElement {
        elements
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_inline_blame(
        &self,
        display_row: DisplayRow,
@ -1827,7 +1821,6 @@ impl EditorElement {
        Some(element)
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_blame_entries(
        &self,
        buffer_rows: &[RowInfo],
@ -1896,7 +1889,6 @@ impl EditorElement {
        Some(shaped_lines)
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_indent_guides(
        &self,
        content_origin: gpui::Point<Pixels>,
@ -2014,7 +2006,6 @@ impl EditorElement {
        (offset_y, length)
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_run_indicators(
        &self,
        line_height: Pixels,
@ -2108,7 +2099,6 @@ impl EditorElement {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_code_actions_indicator(
        &self,
        line_height: Pixels,
@ -2207,7 +2197,6 @@ impl EditorElement {
        relative_rows
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_line_numbers(
        &self,
        gutter_hitbox: Option<&Hitbox>,
@ -2423,7 +2412,6 @@ impl EditorElement {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn prepaint_lines(
        &self,
        start_row: DisplayRow,
@ -2450,7 +2438,6 @@ impl EditorElement {
        line_elements
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_block(
        &self,
        block: &Block,
@ -2950,7 +2937,6 @@ impl EditorElement {
        }))
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_blocks(
        &self,
        rows: Range<DisplayRow>,
@ -3135,7 +3121,6 @@ impl EditorElement {

    /// Returns true if any of the blocks changed size since the previous frame. This will trigger
    /// a restart of rendering for the editor based on the new sizes.
-    #[allow(clippy::too_many_arguments)]
    fn layout_blocks(
        &self,
        blocks: &mut Vec<BlockLayout>,
@ -3179,7 +3164,6 @@ impl EditorElement {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_sticky_buffer_header(
        &self,
        StickyHeaderExcerpt {
@ -3254,7 +3238,6 @@ impl EditorElement {
        header
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_cursor_popovers(
        &self,
        line_height: Pixels,
@ -3443,7 +3426,6 @@ impl EditorElement {
        );
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_gutter_menu(
        &self,
        line_height: Pixels,
@ -3496,7 +3478,6 @@ impl EditorElement {
        );
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_popovers_above_or_below_line(
        &self,
        target_position: gpui::Point<Pixels>,
@ -3610,7 +3591,6 @@ impl EditorElement {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_context_menu_aside(
        &self,
        y_flipped: bool,
@ -3806,7 +3786,6 @@ impl EditorElement {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_hover_popovers(
        &self,
        snapshot: &EditorSnapshot,
@ -3923,7 +3902,6 @@ impl EditorElement {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_diff_hunk_controls(
        &self,
        row_range: Range<DisplayRow>,
@ -4008,7 +3986,6 @@ impl EditorElement {
        controls
    }

-    #[allow(clippy::too_many_arguments)]
    fn layout_signature_help(
        &self,
        hitbox: &Hitbox,
@ -5304,7 +5281,6 @@ impl EditorElement {
        });
    }

-    #[allow(clippy::too_many_arguments)]
    fn paint_highlighted_range(
        &self,
        range: Range<DisplayPoint>,
@ -5730,7 +5706,6 @@ impl AcceptEditPredictionBinding {
    }
 }

-#[allow(clippy::too_many_arguments)]
 fn prepaint_gutter_button(
    button: IconButton,
    row: DisplayRow,
@ -5981,7 +5956,6 @@ impl fmt::Debug for LineFragment {
 }

 impl LineWithInvisibles {
-    #[allow(clippy::too_many_arguments)]
    fn from_chunks<'a>(
        chunks: impl Iterator<Item = HighlightedChunk<'a>>,
        editor_style: &EditorStyle,
@ -6186,7 +6160,6 @@ impl LineWithInvisibles {
        layouts
    }

-    #[allow(clippy::too_many_arguments)]
    fn prepaint(
        &mut self,
        line_height: Pixels,
@ -6221,7 +6194,6 @@ impl LineWithInvisibles {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn draw(
        &self,
        layout: &EditorLayout,
@ -6265,7 +6237,6 @@ impl LineWithInvisibles {
        );
    }

-    #[allow(clippy::too_many_arguments)]
    fn draw_invisibles(
        &self,
        selection_ranges: &[Range<DisplayPoint>],
@ -7659,7 +7630,6 @@ struct ScrollbarRangeData {
 }

 impl ScrollbarRangeData {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        scrollbar_bounds: Bounds<Pixels>,
        letter_size: Size<Pixels>,
--- a/crates/editor/src/scroll.rs
+++ b/crates/editor/src/scroll.rs
@ -223,7 +223,6 @@ impl ScrollManager {
        self.anchor.scroll_position(snapshot)
    }

-    #[allow(clippy::too_many_arguments)]
    fn set_scroll_position(
        &mut self,
        scroll_position: gpui::Point<f32>,
@ -298,7 +297,6 @@ impl ScrollManager {
        );
    }

-    #[allow(clippy::too_many_arguments)]
    fn set_anchor(
        &mut self,
        anchor: ScrollAnchor,
--- a/crates/evals/src/eval.rs
+++ b/crates/evals/src/eval.rs
@ -399,7 +399,6 @@ async fn run_evaluation(
    }
 }

-#[allow(clippy::too_many_arguments)]
 async fn run_eval_project(
    evaluation_project: EvaluationProject,
    user_store: &Entity<UserStore>,
--- a/crates/extension_api/src/extension_api.rs
+++ b/crates/extension_api/src/extension_api.rs
@ -195,7 +195,6 @@ static mut EXTENSION: Option<Box<dyn Extension>> = None;
 pub static ZED_API_VERSION: [u8; 6] = *include_bytes!(concat!(env!("OUT_DIR"), "/version_bytes"));

 mod wit {
-    #![allow(clippy::too_many_arguments, clippy::missing_safety_doc)]

    wit_bindgen::generate!({
        skip: ["init-extension"],
--- a/crates/extension_host/src/extension_host.rs
+++ b/crates/extension_host/src/extension_host.rs
@ -218,7 +218,6 @@ impl ExtensionStore {
        cx.global::<GlobalExtensionStore>().0.clone()
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        extensions_dir: PathBuf,
        build_dir: Option<PathBuf>,
--- a/crates/file_finder/src/file_finder.rs
+++ b/crates/file_finder/src/file_finder.rs
@ -653,7 +653,6 @@ impl FileSearchQuery {
 }

 impl FileFinderDelegate {
-    #[allow(clippy::too_many_arguments)]
    fn new(
        file_finder: WeakEntity<FileFinder>,
        workspace: WeakEntity<Workspace>,
--- a/crates/fuzzy/src/matcher.rs
+++ b/crates/fuzzy/src/matcher.rs
@ -170,7 +170,6 @@ impl<'a> Matcher<'a> {
        score
    }

-    #[allow(clippy::too_many_arguments)]
    fn recursive_score_match(
        &mut self,
        path: &[char],
--- a/crates/gpui/src/platform/linux/wayland/window.rs
+++ b/crates/gpui/src/platform/linux/wayland/window.rs
@ -115,7 +115,6 @@ pub struct WaylandWindowStatePtr {
 }

 impl WaylandWindowState {
-    #[allow(clippy::too_many_arguments)]
    pub(crate) fn new(
        handle: AnyWindowHandle,
        surface: wl_surface::WlSurface,
--- a/crates/gpui/src/platform/linux/x11/window.rs
+++ b/crates/gpui/src/platform/linux/x11/window.rs
@ -353,7 +353,6 @@ where
 }

 impl X11WindowState {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        handle: AnyWindowHandle,
        client: X11ClientStatePtr,
@ -712,7 +711,6 @@ enum WmHintPropertyState {
 }

 impl X11Window {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        handle: AnyWindowHandle,
        client: X11ClientStatePtr,
--- a/crates/gpui/src/text_system/line.rs
+++ b/crates/gpui/src/text_system/line.rs
@ -132,7 +132,6 @@ impl WrappedLine {
    }
 }

-#[allow(clippy::too_many_arguments)]
 fn paint_line(
    origin: Point<Pixels>,
    layout: &LineLayout,
--- a/crates/language/src/syntax_map.rs
+++ b/crates/language/src/syntax_map.rs
@ -1250,7 +1250,6 @@ fn parse_text(
    })
 }

-#[allow(clippy::too_many_arguments)]
 fn get_injections(
    config: &InjectionConfig,
    text: &BufferSnapshot,
--- a/crates/lsp/src/lsp.rs
+++ b/crates/lsp/src/lsp.rs
@ -301,7 +301,6 @@ pub struct AdapterServerCapabilities {

 impl LanguageServer {
    /// Starts a language server process.
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        stderr_capture: Arc<Mutex<Option<String>>>,
        server_id: LanguageServerId,
@ -372,7 +371,6 @@ impl LanguageServer {
        Ok(server)
    }

-    #[allow(clippy::too_many_arguments)]
    fn new_internal<Stdin, Stdout, Stderr, F>(
        server_id: LanguageServerId,
        server_name: LanguageServerName,
--- a/crates/multi_buffer/src/multi_buffer.rs
+++ b/crates/multi_buffer/src/multi_buffer.rs
@ -2982,7 +2982,6 @@ impl MultiBuffer {
        snapshot.check_invariants();
    }

-    #[allow(clippy::too_many_arguments)]
    fn recompute_diff_transforms_for_edit(
        &self,
        edit: &Edit<TypedOffset<Excerpt>>,
--- a/crates/outline_panel/src/outline_panel.rs
+++ b/crates/outline_panel/src/outline_panel.rs
@ -2360,7 +2360,6 @@ impl OutlinePanel {
        )
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_search_match(
        &mut self,
        multi_buffer_snapshot: Option<&MultiBufferSnapshot>,
@ -2452,7 +2451,6 @@ impl OutlinePanel {
        ))
    }

-    #[allow(clippy::too_many_arguments)]
    fn entry_element(
        &self,
        rendered_entry: PanelEntry,
@ -3836,7 +3834,6 @@ impl OutlinePanel {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    fn push_entry(
        &self,
        state: &mut GenerationState,
@ -4054,7 +4051,6 @@ impl OutlinePanel {
        update_cached_entries
    }

-    #[allow(clippy::too_many_arguments)]
    fn add_excerpt_entries(
        &self,
        state: &mut GenerationState,
@ -4113,7 +4109,6 @@ impl OutlinePanel {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn add_search_entries(
        &mut self,
        state: &mut GenerationState,
--- a/crates/project/src/lsp_store.rs
+++ b/crates/project/src/lsp_store.rs
@ -1245,7 +1245,6 @@ impl LocalLspStore {
        Ok(project_transaction)
    }

-    #[allow(clippy::too_many_arguments)]
    async fn execute_formatters(
        lsp_store: WeakEntity<LspStore>,
        formatters: &[Formatter],
@ -1495,7 +1494,6 @@ impl LocalLspStore {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    async fn format_via_lsp(
        this: &WeakEntity<LspStore>,
        buffer: &Entity<Buffer>,
@ -2999,7 +2997,6 @@ impl LspStore {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn new_local(
        buffer_store: Entity<BufferStore>,
        worktree_store: Entity<WorktreeStore>,
@ -3093,7 +3090,6 @@ impl LspStore {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    pub(super) fn new_remote(
        buffer_store: Entity<BufferStore>,
        worktree_store: Entity<WorktreeStore>,
@ -4619,7 +4615,6 @@ impl LspStore {
        Ok(())
    }

-    #[allow(clippy::too_many_arguments)]
    async fn resolve_completion_remote(
        project_id: u64,
        server_id: LanguageServerId,
@ -7736,7 +7731,6 @@ impl LspStore {
        Ok(())
    }

-    #[allow(clippy::too_many_arguments)]
    fn insert_newly_running_language_server(
        &mut self,
        adapter: Arc<CachedLspAdapter>,
--- a/crates/project/src/project.rs
+++ b/crates/project/src/project.rs
@ -1118,7 +1118,6 @@ impl Project {
        .await
    }

-    #[allow(clippy::too_many_arguments)]
    async fn from_join_project_response(
        response: TypedEnvelope<proto::JoinProjectResponse>,
        subscriptions: [EntitySubscription; 5],
--- a/crates/remote/src/ssh_session.rs
+++ b/crates/remote/src/ssh_session.rs
@ -1280,7 +1280,6 @@ impl From<SshRemoteClient> for AnyProtoClient {

 #[async_trait(?Send)]
 trait RemoteConnection: Send + Sync {
-    #[allow(clippy::too_many_arguments)]
    fn start_proxy(
        &self,
        unique_identifier: String,
--- a/crates/rich_text/src/rich_text.rs
+++ b/crates/rich_text/src/rich_text.rs
@ -175,7 +175,6 @@ impl RichText {
    }
 }

-#[allow(clippy::too_many_arguments)]
 pub fn render_markdown_mut(
    block: &str,
    mut mentions: &[Mention],
--- a/crates/semantic_index/src/worktree_index.rs
+++ b/crates/semantic_index/src/worktree_index.rs
@ -116,7 +116,6 @@ impl WorktreeIndex {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        worktree: Entity<Worktree>,
        db_connection: heed::Env,
--- a/crates/terminal/src/terminal.rs
+++ b/crates/terminal/src/terminal.rs
@ -325,7 +325,6 @@ pub struct TerminalBuilder {
 }

 impl TerminalBuilder {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        working_directory: Option<PathBuf>,
        python_venv_directory: Option<PathBuf>,
--- a/crates/terminal_view/src/terminal_element.rs
+++ b/crates/terminal_view/src/terminal_element.rs
@ -171,7 +171,6 @@ impl InteractiveElement for TerminalElement {
 impl StatefulInteractiveElement for TerminalElement {}

 impl TerminalElement {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        terminal: Entity<Terminal>,
        terminal_view: Entity<TerminalView>,
--- a/crates/title_bar/src/collab.rs
+++ b/crates/title_bar/src/collab.rs
@ -191,7 +191,6 @@ impl TitleBar {
            )
    }

-    #[allow(clippy::too_many_arguments)]
    fn render_collaborator(
        &self,
        user: &Arc<User>,
--- a/crates/toolchain_selector/src/toolchain_selector.rs
+++ b/crates/toolchain_selector/src/toolchain_selector.rs
@ -85,7 +85,6 @@ impl ToolchainSelector {
        Some(())
    }

-    #[allow(clippy::too_many_arguments)]
    fn new(
        workspace: WeakEntity<Workspace>,
        project: Entity<Project>,
@ -143,7 +142,6 @@ pub struct ToolchainSelectorDelegate {
 }

 impl ToolchainSelectorDelegate {
-    #[allow(clippy::too_many_arguments)]
    fn new(
        active_toolchain: Option<Toolchain>,
        toolchain_selector: WeakEntity<ToolchainSelector>,
--- a/crates/workspace/src/pane.rs
+++ b/crates/workspace/src/pane.rs
@ -843,7 +843,6 @@ impl Pane {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub(crate) fn open_item(
        &mut self,
        project_entry_id: Option<ProjectEntryId>,
@ -928,7 +927,6 @@ impl Pane {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn add_item_inner(
        &mut self,
        item: Box<dyn ItemHandle>,
--- a/crates/workspace/src/pane_group.rs
+++ b/crates/workspace/src/pane_group.rs
@ -122,7 +122,6 @@ impl PaneGroup {
        };
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn render(
        &self,
        project: &Entity<Project>,
@ -221,7 +220,6 @@ impl Member {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn render(
        &self,
        project: &Entity<Project>,
@ -671,7 +669,6 @@ impl PaneAxis {
        None
    }

-    #[allow(clippy::too_many_arguments)]
    fn render(
        &self,
        project: &Entity<Project>,
@ -875,7 +872,6 @@ mod element {
            self
        }

-        #[allow(clippy::too_many_arguments)]
        fn compute_resize(
            flexes: &Arc<Mutex<Vec<f32>>>,
            e: &MouseMoveEvent,
@ -965,7 +961,6 @@ mod element {
            window.refresh();
        }

-        #[allow(clippy::too_many_arguments)]
        fn layout_handle(
            axis: Axis,
            pane_bounds: Bounds<Pixels>,
--- a/crates/workspace/src/workspace.rs
+++ b/crates/workspace/src/workspace.rs
@ -2732,7 +2732,6 @@ impl Workspace {
        )
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn add_item(
        &mut self,
        pane: Entity<Pane>,
@ -2830,7 +2829,6 @@ impl Workspace {
        self.open_path_preview(path, pane, focus_item, false, true, window, cx)
    }

-    #[allow(clippy::too_many_arguments)]
    pub fn open_path_preview(
        &mut self,
        path: impl Into<ProjectPath>,
--- a/crates/zeta/src/zeta.rs
+++ b/crates/zeta/src/zeta.rs
@ -353,7 +353,6 @@ impl Zeta {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn request_completion_impl<F, R>(
        &mut self,
        workspace: Option<Entity<Workspace>>,
@ -791,7 +790,6 @@ and then another
        }
    }

-    #[allow(clippy::too_many_arguments)]
    fn process_completion_response(
        prediction_response: PredictEditsResponse,
        buffer: Entity<Buffer>,