Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

assistant2: Fix keyboard navigation issues when a picker is open (#25928)

Browse source 
This fixes:
- Bug: Using "up" in model selector triggers assistant2::FocusUp not
menu::SelectPrev
- Bug: Pressing arrow up/down in the model selector opened in the inline
assistant doesn't work
- Bug: Dismissing the model selector with Esc is not working
- Bug: Dismissing context pickers with Esc no longer working

Release Notes:

- N/A
This commit is contained in:
Bennet Bo Fenner 2025-03-03 17:02:25 +01:00 • committed by GitHub
parent d5bc7b9a79
commit 669082dbe0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
assets/keymaps/default-linux.json
View file

@ -779,6 +779,9 @@
{ {
"context": "Picker > Editor", "context": "Picker > Editor",
"bindings": { "bindings": {
"escape": "menu::Cancel",
"up": "menu::SelectPrevious",
"down": "menu::SelectNext",
"tab": "picker::ConfirmCompletion", "tab": "picker::ConfirmCompletion",
"alt-enter": ["picker::ConfirmInput", { "secondary": false }] "alt-enter": ["picker::ConfirmInput", { "secondary": false }]
} }

3
assets/keymaps/default-macos.json
View file

@ -798,6 +798,9 @@
"context": "Picker > Editor", "context": "Picker > Editor",
"use_key_equivalents": true, "use_key_equivalents": true,
"bindings": { "bindings": {
"escape": "menu::Cancel",
"up": "menu::SelectPrevious",
"down": "menu::SelectNext",
"tab": "picker::ConfirmCompletion", "tab": "picker::ConfirmCompletion",
"alt-enter": ["picker::ConfirmInput", { "secondary": false }], "alt-enter": ["picker::ConfirmInput", { "secondary": false }],
"cmd-alt-enter": ["picker::ConfirmInput", { "secondary": true }] "cmd-alt-enter": ["picker::ConfirmInput", { "secondary": true }]