Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use item context for pane tab context menu (#21254)

Browse source 
This allows to show proper override values for terminal tabs in Linux
and Windows.

Release Notes:

- Fixed incorrect "close tab" keybinding shown in context menu of the
terminal panel tabs on Linux and Windows
This commit is contained in:
Kirill Bulatov 2024-11-28 00:30:33 +02:00 • committed by GitHub
parent e803815b16
commit 66ba9d5b4b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/workspace/src/pane.rs
View file

@ -2075,8 +2075,10 @@ impl Pane {
let is_pinned = self.is_tab_pinned(ix); let is_pinned = self.is_tab_pinned(ix);
let pane = cx.view().downgrade(); let pane = cx.view().downgrade();
let menu_context = item.focus_handle(cx);
right_click_menu(ix).trigger(tab).menu(move |cx| { right_click_menu(ix).trigger(tab).menu(move |cx| {
let pane = pane.clone(); let pane = pane.clone();
let menu_context = menu_context.clone();
ContextMenu::build(cx, move |mut menu, cx| { ContextMenu::build(cx, move |mut menu, cx| {
if let Some(pane) = pane.upgrade() { if let Some(pane) = pane.upgrade() {
menu = menu menu = menu
@ -2255,7 +2257,7 @@ impl Pane {
} }
} }
menu menu.context(menu_context)
}) })
}) })
} }