Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Return impl IntoElement from RenderOnce::render

Browse source 
This makes it a bit more approachable to implement.

This required converting the state of Component to AnyElement, which
costs an allocation. I'm hoping this will be ok performance-wise now
that AnyElements use bump allocation, but I need to benchmark still.
This commit is contained in:
Nathan Sobo 2024-01-02 10:27:09 -07:00
parent 1b5c8b2b4a
commit 68e7d99219
35 changed files with 74 additions and 183 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/story/src/story.rs
View file

@ -1,6 +1,5 @@
use gpui::{
div, hsla, prelude::*, px, rems, AnyElement, Div, ElementId, Hsla, SharedString, Stateful,
WindowContext,
div, hsla, prelude::*, px, rems, AnyElement, Div, ElementId, Hsla, SharedString, WindowContext,
};
use itertools::Itertools;
use smallvec::SmallVec;
@ -74,9 +73,7 @@ impl ParentElement for StoryContainer {
}
impl RenderOnce for StoryContainer {
type Output = Stateful<Div>;
fn render(self, _cx: &mut WindowContext) -> Self::Output {
fn render(self, _cx: &mut WindowContext) -> impl IntoElement {
div()
.size_full()
.flex()
@ -294,9 +291,7 @@ impl StoryItem {
}
impl RenderOnce for StoryItem {
type Output = Div;
fn render(self, _cx: &mut WindowContext) -> Self::Output {
fn render(self, _cx: &mut WindowContext) -> impl IntoElement {
div()
.my_2()
.flex()
@ -358,9 +353,7 @@ impl StorySection {
}
impl RenderOnce for StorySection {
type Output = Div;
fn render(self, _cx: &mut WindowContext) -> Self::Output {
fn render(self, _cx: &mut WindowContext) -> impl IntoElement {
let children: SmallVec<[AnyElement; 2]> = SmallVec::from_iter(Itertools::intersperse_with(
self.children.into_iter(),
|| Story::divider().into_any_element(),