Fix slow focus transitions to the terminal panel (#24172)
This long standing bug was caused by `Pane`'s focus_in handler bouncing the focus to another handle. Because focus resolution happens _after_ a frame has been rendered, the only way to deal with this case is to schedule another frame to be redrawn. However, we where suppressing all window refreshes that occur during a focus transfer, causing this focus change to be completely missed. However, changing this behavior can lead to infinite notify loops, due to drawing a frame causing another to be rendered. This PR fixes this problem narrowly by adding an `on_next_frame()` callback in the pane's focus handle, so that the focus changes take effect almost immediately. But only for this case, where we know it doesn't cause infinite notify loops. TODO: - [x] Fix the infinite notify loop bug or determine a third way to fix this lag Release Notes: - Fixed a bug where shifting focus to the terminal panel could be slow
This commit is contained in:
parent
cfe0932c0a
commit
69bb0a0597
2 changed files with 7 additions and 2 deletions
|
@ -582,6 +582,11 @@ impl Pane {
|
|||
|
||||
if let Some(active_item) = self.active_item() {
|
||||
if self.focus_handle.is_focused(window) {
|
||||
// Schedule a redraw next frame, so that the focus changes below take effect
|
||||
cx.on_next_frame(window, |_, _, cx| {
|
||||
cx.notify();
|
||||
});
|
||||
|
||||
// Pane was focused directly. We need to either focus a view inside the active item,
|
||||
// or focus the active item itself
|
||||
if let Some(weak_last_focus_handle) =
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue