Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable clippy::unnecessary_operation (#8752)

Browse source 
This PR enables the
[`clippy::unnecessary_operation`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_operation)
rule and fixes the outstanding violations.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-03-02 22:19:56 -05:00 • committed by GitHub
parent ea68f86476
commit 6a9e8faad2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/collab/src/db/tests/contributor_tests.rs
View file

@ -18,8 +18,7 @@ async fn test_contributors(db: &Arc<Database>) {
}, },
) )
.await .await
.unwrap() .unwrap();
.user_id;
assert_eq!(db.get_contributors().await.unwrap(), Vec::<String>::new()); assert_eq!(db.get_contributors().await.unwrap(), Vec::<String>::new());

3
crates/collab/src/db/tests/db_tests.rs
View file

@ -87,8 +87,7 @@ async fn test_get_or_create_user_by_github_account(db: &Arc<Database>) {
}, },
) )
.await .await
.unwrap() .unwrap();
.user_id;
let user_id2 = db let user_id2 = db
.create_user( .create_user(
"user2@example.com", "user2@example.com",

1
tooling/xtask/src/main.rs
View file

@ -114,7 +114,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
"clippy::single_range_in_vec_init", "clippy::single_range_in_vec_init",
"clippy::suspicious_to_owned", "clippy::suspicious_to_owned",
"clippy::type_complexity", "clippy::type_complexity",
"clippy::unnecessary_operation",
"clippy::unnecessary_to_owned", "clippy::unnecessary_to_owned",
"clippy::unnecessary_unwrap", "clippy::unnecessary_unwrap",
"clippy::useless_conversion", "clippy::useless_conversion",