Revert "debugger beta: Fix bug where debug Rust main running action f… (#31743)
…ailed (#31291)"
This reverts commit aab76208b5
.
Closes #31737
I cannot repro the original issue that this commit was trying to solve
anymore.
Release Notes:
- N/A
This commit is contained in:
parent
e0fa3032ec
commit
6bb4b5fa64
2 changed files with 8 additions and 42 deletions
|
@ -874,7 +874,6 @@ impl RunningState {
|
||||||
args,
|
args,
|
||||||
..task.resolved.clone()
|
..task.resolved.clone()
|
||||||
};
|
};
|
||||||
|
|
||||||
let terminal = project
|
let terminal = project
|
||||||
.update_in(cx, |project, window, cx| {
|
.update_in(cx, |project, window, cx| {
|
||||||
project.create_terminal(
|
project.create_terminal(
|
||||||
|
@ -919,6 +918,12 @@ impl RunningState {
|
||||||
};
|
};
|
||||||
|
|
||||||
if config_is_valid {
|
if config_is_valid {
|
||||||
|
// Ok(DebugTaskDefinition {
|
||||||
|
// label,
|
||||||
|
// adapter: DebugAdapterName(adapter),
|
||||||
|
// config,
|
||||||
|
// tcp_connection,
|
||||||
|
// })
|
||||||
} else if let Some((task, locator_name)) = build_output {
|
} else if let Some((task, locator_name)) = build_output {
|
||||||
let locator_name =
|
let locator_name =
|
||||||
locator_name.context("Could not find a valid locator for a build task")?;
|
locator_name.context("Could not find a valid locator for a build task")?;
|
||||||
|
@ -937,7 +942,7 @@ impl RunningState {
|
||||||
|
|
||||||
let scenario = dap_registry
|
let scenario = dap_registry
|
||||||
.adapter(&adapter)
|
.adapter(&adapter)
|
||||||
.context(format!("{}: is not a valid adapter name", &adapter))
|
.ok_or_else(|| anyhow!("{}: is not a valid adapter name", &adapter))
|
||||||
.map(|adapter| adapter.config_from_zed_format(zed_config))??;
|
.map(|adapter| adapter.config_from_zed_format(zed_config))??;
|
||||||
config = scenario.config;
|
config = scenario.config;
|
||||||
Self::substitute_variables_in_config(&mut config, &task_context);
|
Self::substitute_variables_in_config(&mut config, &task_context);
|
||||||
|
|
|
@ -237,18 +237,6 @@ impl TaskTemplate {
|
||||||
env
|
env
|
||||||
};
|
};
|
||||||
|
|
||||||
// We filter out env variables here that aren't set so we don't have extra white space in args
|
|
||||||
let args = self
|
|
||||||
.args
|
|
||||||
.iter()
|
|
||||||
.filter(|arg| {
|
|
||||||
arg.starts_with('$')
|
|
||||||
.then(|| env.get(&arg[1..]).is_some_and(|arg| !arg.trim().is_empty()))
|
|
||||||
.unwrap_or(true)
|
|
||||||
})
|
|
||||||
.cloned()
|
|
||||||
.collect();
|
|
||||||
|
|
||||||
Some(ResolvedTask {
|
Some(ResolvedTask {
|
||||||
id: id.clone(),
|
id: id.clone(),
|
||||||
substituted_variables,
|
substituted_variables,
|
||||||
|
@ -268,7 +256,7 @@ impl TaskTemplate {
|
||||||
},
|
},
|
||||||
),
|
),
|
||||||
command,
|
command,
|
||||||
args,
|
args: self.args.clone(),
|
||||||
env,
|
env,
|
||||||
use_new_terminal: self.use_new_terminal,
|
use_new_terminal: self.use_new_terminal,
|
||||||
allow_concurrent_runs: self.allow_concurrent_runs,
|
allow_concurrent_runs: self.allow_concurrent_runs,
|
||||||
|
@ -715,7 +703,6 @@ mod tests {
|
||||||
label: "My task".into(),
|
label: "My task".into(),
|
||||||
command: "echo".into(),
|
command: "echo".into(),
|
||||||
args: vec!["$PATH".into()],
|
args: vec!["$PATH".into()],
|
||||||
env: HashMap::from_iter([("PATH".to_owned(), "non-empty".to_owned())]),
|
|
||||||
..TaskTemplate::default()
|
..TaskTemplate::default()
|
||||||
};
|
};
|
||||||
let resolved_task = task
|
let resolved_task = task
|
||||||
|
@ -728,32 +715,6 @@ mod tests {
|
||||||
assert_eq!(resolved.args, task.args);
|
assert_eq!(resolved.args, task.args);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_empty_env_variables_excluded_from_args() {
|
|
||||||
let task = TaskTemplate {
|
|
||||||
label: "My task".into(),
|
|
||||||
command: "echo".into(),
|
|
||||||
args: vec![
|
|
||||||
"$EMPTY_VAR".into(),
|
|
||||||
"hello".into(),
|
|
||||||
"$WHITESPACE_VAR".into(),
|
|
||||||
"$UNDEFINED_VAR".into(),
|
|
||||||
"$WORLD".into(),
|
|
||||||
],
|
|
||||||
env: HashMap::from_iter([
|
|
||||||
("EMPTY_VAR".to_owned(), "".to_owned()),
|
|
||||||
("WHITESPACE_VAR".to_owned(), " ".to_owned()),
|
|
||||||
("WORLD".to_owned(), "non-empty".to_owned()),
|
|
||||||
]),
|
|
||||||
..TaskTemplate::default()
|
|
||||||
};
|
|
||||||
let resolved_task = task
|
|
||||||
.resolve_task(TEST_ID_BASE, &TaskContext::default())
|
|
||||||
.unwrap();
|
|
||||||
let resolved = resolved_task.resolved;
|
|
||||||
assert_eq!(resolved.args, vec!["hello", "$WORLD"]);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_errors_on_missing_zed_variable() {
|
fn test_errors_on_missing_zed_variable() {
|
||||||
let task = TaskTemplate {
|
let task = TaskTemplate {
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue