From 6c46e1129df58c9cda15cf028a51c44868f1565d Mon Sep 17 00:00:00 2001 From: Ben Brandt Date: Fri, 27 Jun 2025 10:32:13 +0200 Subject: [PATCH] Cleanup remaining references to max mode (#33509) Release Notes: - N/A --- crates/agent/src/thread.rs | 2 +- crates/agent_ui/src/agent_panel.rs | 2 +- crates/agent_ui/src/agent_ui.rs | 2 +- .../src/{max_mode_tooltip.rs => burn_mode_tooltip.rs} | 0 crates/agent_ui/src/message_editor.rs | 2 +- crates/agent_ui/src/text_thread_editor.rs | 10 +++++----- crates/agent_ui/src/ui.rs | 4 ++-- .../ui/{max_mode_tooltip.rs => burn_mode_tooltip.rs} | 0 crates/assistant_context/src/assistant_context.rs | 6 +++--- crates/language_model/src/language_model.rs | 2 +- crates/language_models/src/provider/cloud.rs | 2 +- 11 files changed, 16 insertions(+), 16 deletions(-) rename crates/agent_ui/src/{max_mode_tooltip.rs => burn_mode_tooltip.rs} (100%) rename crates/agent_ui/src/ui/{max_mode_tooltip.rs => burn_mode_tooltip.rs} (100%) diff --git a/crates/agent/src/thread.rs b/crates/agent/src/thread.rs index 68624d7c3b..32c376ca67 100644 --- a/crates/agent/src/thread.rs +++ b/crates/agent/src/thread.rs @@ -1419,7 +1419,7 @@ impl Thread { } request.tools = available_tools; - request.mode = if model.supports_max_mode() { + request.mode = if model.supports_burn_mode() { Some(self.completion_mode.into()) } else { Some(CompletionMode::Normal.into()) diff --git a/crates/agent_ui/src/agent_panel.rs b/crates/agent_ui/src/agent_panel.rs index e7e7b6da13..560e87b1c2 100644 --- a/crates/agent_ui/src/agent_panel.rs +++ b/crates/agent_ui/src/agent_panel.rs @@ -2656,7 +2656,7 @@ impl AgentPanel { this.continue_conversation(window, cx); })), ) - .when(model.supports_max_mode(), |this| { + .when(model.supports_burn_mode(), |this| { this.child( Button::new("continue-burn-mode", "Continue with Burn Mode") .style(ButtonStyle::Filled) diff --git a/crates/agent_ui/src/agent_ui.rs b/crates/agent_ui/src/agent_ui.rs index 4babe4f676..29a4f38487 100644 --- a/crates/agent_ui/src/agent_ui.rs +++ b/crates/agent_ui/src/agent_ui.rs @@ -4,6 +4,7 @@ mod agent_diff; mod agent_model_selector; mod agent_panel; mod buffer_codegen; +mod burn_mode_tooltip; mod context_picker; mod context_server_configuration; mod context_strip; @@ -11,7 +12,6 @@ mod debug; mod inline_assistant; mod inline_prompt_editor; mod language_model_selector; -mod max_mode_tooltip; mod message_editor; mod profile_selector; mod slash_command; diff --git a/crates/agent_ui/src/max_mode_tooltip.rs b/crates/agent_ui/src/burn_mode_tooltip.rs similarity index 100% rename from crates/agent_ui/src/max_mode_tooltip.rs rename to crates/agent_ui/src/burn_mode_tooltip.rs diff --git a/crates/agent_ui/src/message_editor.rs b/crates/agent_ui/src/message_editor.rs index 39f83d50cb..015b50a801 100644 --- a/crates/agent_ui/src/message_editor.rs +++ b/crates/agent_ui/src/message_editor.rs @@ -575,7 +575,7 @@ impl MessageEditor { fn render_burn_mode_toggle(&self, cx: &mut Context) -> Option { let thread = self.thread.read(cx); let model = thread.configured_model(); - if !model?.model.supports_max_mode() { + if !model?.model.supports_burn_mode() { return None; } diff --git a/crates/agent_ui/src/text_thread_editor.rs b/crates/agent_ui/src/text_thread_editor.rs index c035282c92..49e5e27254 100644 --- a/crates/agent_ui/src/text_thread_editor.rs +++ b/crates/agent_ui/src/text_thread_editor.rs @@ -1,8 +1,8 @@ use crate::{ + burn_mode_tooltip::MaxModeTooltip, language_model_selector::{ LanguageModelSelector, ToggleModelSelector, language_model_selector, }, - max_mode_tooltip::MaxModeTooltip, }; use agent_settings::{AgentSettings, CompletionMode}; use anyhow::Result; @@ -2075,12 +2075,12 @@ impl TextThreadEditor { ) } - fn render_max_mode_toggle(&self, cx: &mut Context) -> Option { + fn render_burn_mode_toggle(&self, cx: &mut Context) -> Option { let context = self.context().read(cx); let active_model = LanguageModelRegistry::read_global(cx) .default_model() .map(|default| default.model)?; - if !active_model.supports_max_mode() { + if !active_model.supports_burn_mode() { return None; } @@ -2575,7 +2575,7 @@ impl Render for TextThreadEditor { }; let language_model_selector = self.language_model_selector_menu_handle.clone(); - let max_mode_toggle = self.render_max_mode_toggle(cx); + let burn_mode_toggle = self.render_burn_mode_toggle(cx); v_flex() .key_context("ContextEditor") @@ -2630,7 +2630,7 @@ impl Render for TextThreadEditor { h_flex() .gap_0p5() .child(self.render_inject_context_menu(cx)) - .when_some(max_mode_toggle, |this, element| this.child(element)), + .when_some(burn_mode_toggle, |this, element| this.child(element)), ) .child( h_flex() diff --git a/crates/agent_ui/src/ui.rs b/crates/agent_ui/src/ui.rs index c9adc2a631..c076d113b8 100644 --- a/crates/agent_ui/src/ui.rs +++ b/crates/agent_ui/src/ui.rs @@ -1,13 +1,13 @@ mod agent_notification; mod animated_label; +mod burn_mode_tooltip; mod context_pill; -mod max_mode_tooltip; mod onboarding_modal; pub mod preview; mod upsell; pub use agent_notification::*; pub use animated_label::*; +pub use burn_mode_tooltip::*; pub use context_pill::*; -pub use max_mode_tooltip::*; pub use onboarding_modal::*; diff --git a/crates/agent_ui/src/ui/max_mode_tooltip.rs b/crates/agent_ui/src/ui/burn_mode_tooltip.rs similarity index 100% rename from crates/agent_ui/src/ui/max_mode_tooltip.rs rename to crates/agent_ui/src/ui/burn_mode_tooltip.rs diff --git a/crates/assistant_context/src/assistant_context.rs b/crates/assistant_context/src/assistant_context.rs index cef9d2f0fd..0be8afcf69 100644 --- a/crates/assistant_context/src/assistant_context.rs +++ b/crates/assistant_context/src/assistant_context.rs @@ -2346,13 +2346,13 @@ impl AssistantContext { completion_request.messages.push(request_message); } } - let supports_max_mode = if let Some(model) = model { - model.supports_max_mode() + let supports_burn_mode = if let Some(model) = model { + model.supports_burn_mode() } else { false }; - if supports_max_mode { + if supports_burn_mode { completion_request.mode = Some(self.completion_mode.into()); } completion_request diff --git a/crates/language_model/src/language_model.rs b/crates/language_model/src/language_model.rs index f84357bd98..ccde40c05f 100644 --- a/crates/language_model/src/language_model.rs +++ b/crates/language_model/src/language_model.rs @@ -294,7 +294,7 @@ pub trait LanguageModel: Send + Sync { fn supports_tool_choice(&self, choice: LanguageModelToolChoice) -> bool; /// Returns whether this model supports "burn mode"; - fn supports_max_mode(&self) -> bool { + fn supports_burn_mode(&self) -> bool { false } diff --git a/crates/language_models/src/provider/cloud.rs b/crates/language_models/src/provider/cloud.rs index 58902850ea..62a24282dd 100644 --- a/crates/language_models/src/provider/cloud.rs +++ b/crates/language_models/src/provider/cloud.rs @@ -695,7 +695,7 @@ impl LanguageModel for CloudLanguageModel { } } - fn supports_max_mode(&self) -> bool { + fn supports_burn_mode(&self) -> bool { self.model.supports_max_mode }