Stop using xtask for clippy (#13223)

This fixes an extra 10 second delay when needing to recompile xtask, and
allows passing arbitrary clippy args (like --allow-dirty)

Release Notes:

- N/A

script/check-licenses

@@ -0,0 +1,20 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+check_license () {
+    for license in "LICENSE-AGPL" "LICENSE-GPL" "LICENSE-APACHE"; do
+        if [[ -L "$1/$license" ]]; then
+            return 0
+        elif [[ -e "$1/$license" ]]; then
+            echo "Error: $1/$license exists but is not a symlink."
+            exit 1
+        fi
+    done
+    echo "Error: $1 does not contain a license symlink"
+    exit 1
+}
+
+git ls-files **/*/Cargo.toml | while read cargo_toml; do
+   check_license $(dirname "$cargo_toml");
+done

script/clippy

@@ -1,5 +1,10 @@
 #!/usr/bin/env bash
 
-set -euxo pipefail
+set -euo pipefail
 
-cargo xtask clippy
+if [[ ! " $* " == *" -p "* && ! " $* " == *" --package "* ]]; then
+    set -- "$@" --workspace
+fi
+
+set -x
+"${CARGO:-cargo}" clippy "$@" --release --all-targets --all-features -- --deny warnings