debugger beta: Fix regression where we sent launch args twice to any dap (#31325)

This regression happens because our tests weren't properly catching this
edge case anymore. I updated the tests to only send the raw config to
the Fake Adapter Client.

Release Notes:

- debugger beta: Fix bug where launch args were sent twice
This commit is contained in:
Anthony Eid 2025-05-24 09:52:36 +03:00 committed by GitHub
parent 7fb9569c15
commit 6f918ed99b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 39 deletions

View file

@ -50,7 +50,7 @@ use std::{
sync::{Arc, Once},
};
use task::{DebugScenario, SpawnInTerminal, TaskTemplate};
use util::{ResultExt as _, merge_json_value_into};
use util::ResultExt as _;
use worktree::Worktree;
#[derive(Debug)]
@ -407,14 +407,12 @@ impl DapStore {
cx.spawn({
let session = session.clone();
async move |this, cx| {
let mut binary = this
let binary = this
.update(cx, |this, cx| {
this.get_debug_adapter_binary(definition.clone(), session_id, console, cx)
})?
.await?;
merge_json_value_into(definition.config, &mut binary.request_args.configuration);
session
.update(cx, |session, cx| {
session.boot(binary, worktree, dap_store, cx)