Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Check validity of new.range too (#12781)

Browse source 
I'm not certain yet how it could be invalid, but we are still seeing
panics here.

Release Notes:

- Fixed a panic when opening the diagnostics view
This commit is contained in:
Conrad Irwin 2024-06-07 11:48:23 -06:00 • committed by GitHub
parent 834089feb1
commit 6fa6e0718c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/diagnostics/src/diagnostics.rs
View file

@ -867,10 +867,12 @@ fn compare_diagnostics(
snapshot: &language::BufferSnapshot, snapshot: &language::BufferSnapshot,
) -> Ordering { ) -> Ordering {
use language::ToOffset; use language::ToOffset;
// The old diagnostics may point to a previously open Buffer for this file.
if !old.range.start.is_valid(snapshot) { // The diagnostics may point to a previously open Buffer for this file.
if !old.range.start.is_valid(snapshot) || !new.range.start.is_valid(snapshot) {
return Ordering::Greater; return Ordering::Greater;
} }
old.range old.range
.start .start
.to_offset(snapshot) .to_offset(snapshot)