windows: Make collab run on Windows (#23117)

I’ve also updated the documentation in
`development\local-collaboration.md` and
`docs\src\development\windows.md`.

Testing collab on my Windows machine:

![屏幕截图 2025-01-14
162021](https://github.com/user-attachments/assets/28b4a36a-e156-4012-981a-5d0a23dcc613)


Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

crates/livekit_client/Cargo.toml

@@ -18,11 +18,7 @@ name = "test_app"
 
 [features]
 no-webrtc = []
-test-support = [
-    "collections/test-support",
-    "gpui/test-support",
-    "nanoid",
-]
+test-support = ["collections/test-support", "gpui/test-support", "nanoid"]
 
 [dependencies]
 anyhow.workspace = true
@@ -32,10 +28,11 @@ cpal = "0.15"
 futures.workspace = true
 gpui.workspace = true
 http_2 = { package = "http", version = "0.2.1" }
+livekit.workspace = true
 livekit_server.workspace = true
 log.workspace = true
 media.workspace = true
-nanoid = { workspace = true, optional = true}
+nanoid = { workspace = true, optional = true }
 parking_lot.workspace = true
 postage.workspace = true
 util.workspace = true
@@ -43,9 +40,6 @@ http_client.workspace = true
 smallvec.workspace = true
 image.workspace = true
 
-[target.'cfg(not(target_os = "windows"))'.dependencies]
-livekit.workspace = true
-
 [target.'cfg(target_os = "macos")'.dependencies]
 core-foundation.workspace = true
 coreaudio-rs = "0.12.1"

crates/livekit_client/src/livekit_client.rs

@@ -1,7 +1,5 @@
-#![cfg_attr(target_os = "windows", allow(unused))]
-
 mod remote_video_track_view;
-#[cfg(any(test, feature = "test-support", target_os = "windows"))]
+#[cfg(any(test, feature = "test-support"))]
 pub mod test;
 
 use anyhow::{anyhow, Context as _, Result};
@@ -13,7 +11,6 @@ use gpui::{
 use parking_lot::Mutex;
 use std::{borrow::Cow, collections::VecDeque, future::Future, pin::Pin, sync::Arc, thread};
 use util::{debug_panic, ResultExt as _};
-#[cfg(not(target_os = "windows"))]
 use webrtc::{
     audio_frame::AudioFrame,
     audio_source::{native::NativeAudioSource, AudioSourceOptions, RtcAudioSource},
@@ -23,13 +20,13 @@ use webrtc::{
     video_stream::native::NativeVideoStream,
 };
 
-#[cfg(all(not(any(test, feature = "test-support")), not(target_os = "windows")))]
+#[cfg(not(any(test, feature = "test-support")))]
 use livekit::track::RemoteAudioTrack;
-#[cfg(all(not(any(test, feature = "test-support")), not(target_os = "windows")))]
+#[cfg(not(any(test, feature = "test-support")))]
 pub use livekit::*;
-#[cfg(any(test, feature = "test-support", target_os = "windows"))]
+#[cfg(any(test, feature = "test-support"))]
 use test::track::RemoteAudioTrack;
-#[cfg(any(test, feature = "test-support", target_os = "windows"))]
+#[cfg(any(test, feature = "test-support"))]
 pub use test::*;
 
 pub use remote_video_track_view::{RemoteVideoTrackView, RemoteVideoTrackViewEvent};
@@ -46,7 +43,6 @@ pub enum AudioStream {
 
 struct Dispatcher(Arc<dyn gpui::PlatformDispatcher>);
 
-#[cfg(not(target_os = "windows"))]
 impl livekit::dispatcher::Dispatcher for Dispatcher {
     fn dispatch(&self, runnable: livekit::dispatcher::Runnable) {
         self.0.dispatch(runnable, None);
@@ -68,7 +64,6 @@ fn http_2_status(status: http_client::http::StatusCode) -> http_2::StatusCode {
         .expect("valid status code to status code conversion")
 }
 
-#[cfg(not(target_os = "windows"))]
 impl livekit::dispatcher::HttpClient for HttpClientAdapter {
     fn get(
         &self,
@@ -123,14 +118,6 @@ impl livekit::dispatcher::HttpClient for HttpClientAdapter {
     }
 }
 
-#[cfg(target_os = "windows")]
-pub fn init(
-    dispatcher: Arc<dyn gpui::PlatformDispatcher>,
-    http_client: Arc<dyn http_client::HttpClient>,
-) {
-}
-
-#[cfg(not(target_os = "windows"))]
 pub fn init(
     dispatcher: Arc<dyn gpui::PlatformDispatcher>,
     http_client: Arc<dyn http_client::HttpClient>,
@@ -139,7 +126,6 @@ pub fn init(
     livekit::dispatcher::set_http_client(HttpClientAdapter(http_client));
 }
 
-#[cfg(not(target_os = "windows"))]
 pub async fn capture_local_video_track(
     capture_source: &dyn ScreenCaptureSource,
 ) -> Result<(track::LocalVideoTrack, Box<dyn ScreenCaptureStream>)> {
@@ -173,7 +159,6 @@ pub async fn capture_local_video_track(
     ))
 }
 
-#[cfg(not(target_os = "windows"))]
 pub fn capture_local_audio_track(
     background_executor: &BackgroundExecutor,
 ) -> Result<Task<(track::LocalAudioTrack, AudioStream)>> {
@@ -265,7 +250,6 @@ pub fn capture_local_audio_track(
     }))
 }
 
-#[cfg(not(target_os = "windows"))]
 pub fn play_remote_audio_track(
     track: &RemoteAudioTrack,
     background_executor: &BackgroundExecutor,
@@ -336,7 +320,6 @@ fn default_device(input: bool) -> anyhow::Result<(cpal::Device, cpal::SupportedS
     Ok((device, config))
 }
 
-#[cfg(not(target_os = "windows"))]
 fn get_default_output() -> anyhow::Result<(cpal::Device, cpal::SupportedStreamConfig)> {
     let host = cpal::default_host();
     let output_device = host
@@ -346,7 +329,6 @@ fn get_default_output() -> anyhow::Result<(cpal::Device, cpal::SupportedStreamCo
     Ok((output_device, output_config))
 }
 
-#[cfg(not(target_os = "windows"))]
 fn start_output_stream(
     output_config: cpal::SupportedStreamConfig,
     output_device: cpal::Device,
@@ -431,14 +413,6 @@ fn start_output_stream(
     (receive_task, thread)
 }
 
-#[cfg(target_os = "windows")]
-pub fn play_remote_video_track(
-    track: &track::RemoteVideoTrack,
-) -> impl Stream<Item = RemoteVideoFrame> {
-    futures::stream::empty()
-}
-
-#[cfg(not(target_os = "windows"))]
 pub fn play_remote_video_track(
     track: &track::RemoteVideoTrack,
 ) -> impl Stream<Item = RemoteVideoFrame> {
@@ -466,7 +440,7 @@ fn video_frame_buffer_from_webrtc(buffer: Box<dyn VideoBuffer>) -> Option<Remote
 #[cfg(not(target_os = "macos"))]
 pub type RemoteVideoFrame = Arc<gpui::RenderImage>;
 
-#[cfg(not(any(target_os = "macos", target_os = "windows")))]
+#[cfg(not(target_os = "macos"))]
 fn video_frame_buffer_from_webrtc(buffer: Box<dyn VideoBuffer>) -> Option<RemoteVideoFrame> {
     use gpui::RenderImage;
     use image::{Frame, RgbaImage};
@@ -517,7 +491,7 @@ fn video_frame_buffer_to_webrtc(frame: ScreenCaptureFrame) -> Option<impl AsRef<
     }
 }
 
-#[cfg(not(any(target_os = "macos", target_os = "windows")))]
+#[cfg(not(target_os = "macos"))]
 fn video_frame_buffer_to_webrtc(_frame: ScreenCaptureFrame) -> Option<impl AsRef<dyn VideoBuffer>> {
     None as Option<Box<dyn VideoBuffer>>
 }

crates/livekit_client/src/test.rs

@@ -1,18 +1,14 @@
 pub mod participant;
 pub mod publication;
 pub mod track;
-
-#[cfg(not(windows))]
 pub mod webrtc;
 
-#[cfg(not(windows))]
 use self::id::*;
 use self::{participant::*, publication::*, track::*};
 use anyhow::{anyhow, Context, Result};
 use async_trait::async_trait;
 use collections::{btree_map::Entry as BTreeEntry, hash_map::Entry, BTreeMap, HashMap, HashSet};
 use gpui::BackgroundExecutor;
-#[cfg(not(windows))]
 use livekit::options::TrackPublishOptions;
 use livekit_server::{proto, token};
 use parking_lot::Mutex;
@@ -22,7 +18,6 @@ use std::sync::{
     Arc, Weak,
 };
 
-#[cfg(not(windows))]
 pub use livekit::{id, options, ConnectionState, DisconnectReason, RoomOptions};
 
 static SERVERS: Mutex<BTreeMap<String, Arc<TestServer>>> = Mutex::new(BTreeMap::new());
@@ -31,12 +26,10 @@ pub struct TestServer {
     pub url: String,
     pub api_key: String,
     pub secret_key: String,
-    #[cfg(not(target_os = "windows"))]
     rooms: Mutex<HashMap<String, TestServerRoom>>,
     executor: BackgroundExecutor,
 }
 
-#[cfg(not(target_os = "windows"))]
 impl TestServer {
     pub fn create(
         url: String,
@@ -534,7 +527,6 @@ impl TestServer {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 #[derive(Default, Debug)]
 struct TestServerRoom {
     client_rooms: HashMap<ParticipantIdentity, Room>,
@@ -543,7 +535,6 @@ struct TestServerRoom {
     participant_permissions: HashMap<ParticipantIdentity, proto::ParticipantPermission>,
 }
 
-#[cfg(not(target_os = "windows"))]
 #[derive(Debug)]
 struct TestServerVideoTrack {
     sid: TrackSid,
@@ -551,7 +542,6 @@ struct TestServerVideoTrack {
     // frames_rx: async_broadcast::Receiver<Frame>,
 }
 
-#[cfg(not(target_os = "windows"))]
 #[derive(Debug)]
 struct TestServerAudioTrack {
     sid: TrackSid,
@@ -590,7 +580,6 @@ pub enum RoomEvent {
     TrackSubscriptionFailed {
         participant: RemoteParticipant,
         error: String,
-        #[cfg(not(target_os = "windows"))]
         track_sid: TrackSid,
     },
     TrackPublished {
@@ -626,12 +615,10 @@ pub enum RoomEvent {
     ActiveSpeakersChanged {
         speakers: Vec<Participant>,
     },
-    #[cfg(not(target_os = "windows"))]
     ConnectionStateChanged(ConnectionState),
     Connected {
         participants_with_tracks: Vec<(RemoteParticipant, Vec<RemoteTrackPublication>)>,
     },
-    #[cfg(not(target_os = "windows"))]
     Disconnected {
         reason: DisconnectReason,
     },
@@ -639,7 +626,6 @@ pub enum RoomEvent {
     Reconnected,
 }
 
-#[cfg(not(target_os = "windows"))]
 #[async_trait]
 impl livekit_server::api::Client for TestApiClient {
     fn url(&self) -> &str {
@@ -703,11 +689,8 @@ impl livekit_server::api::Client for TestApiClient {
 struct RoomState {
     url: String,
     token: String,
-    #[cfg(not(target_os = "windows"))]
     local_identity: ParticipantIdentity,
-    #[cfg(not(target_os = "windows"))]
     connection_state: ConnectionState,
-    #[cfg(not(target_os = "windows"))]
     paused_audio_tracks: HashSet<TrackSid>,
     updates_tx: mpsc::Sender<RoomEvent>,
 }
@@ -718,7 +701,6 @@ pub struct Room(Arc<Mutex<RoomState>>);
 #[derive(Clone, Debug)]
 pub(crate) struct WeakRoom(Weak<Mutex<RoomState>>);
 
-#[cfg(not(target_os = "windows"))]
 impl std::fmt::Debug for RoomState {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         f.debug_struct("Room")
@@ -731,17 +713,6 @@ impl std::fmt::Debug for RoomState {
     }
 }
 
-#[cfg(target_os = "windows")]
-impl std::fmt::Debug for RoomState {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        f.debug_struct("Room")
-            .field("url", &self.url)
-            .field("token", &self.token)
-            .finish()
-    }
-}
-
-#[cfg(not(target_os = "windows"))]
 impl Room {
     fn downgrade(&self) -> WeakRoom {
         WeakRoom(Arc::downgrade(&self.0))
@@ -803,7 +774,6 @@ impl Room {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl Drop for RoomState {
     fn drop(&mut self) {
         if self.connection_state == ConnectionState::Connected {

crates/livekit_client/src/test/participant.rs

@@ -8,19 +8,16 @@ pub enum Participant {
 
 #[derive(Clone, Debug)]
 pub struct LocalParticipant {
-    #[cfg(not(target_os = "windows"))]
     pub(super) identity: ParticipantIdentity,
     pub(super) room: Room,
 }
 
 #[derive(Clone, Debug)]
 pub struct RemoteParticipant {
-    #[cfg(not(target_os = "windows"))]
     pub(super) identity: ParticipantIdentity,
     pub(super) room: WeakRoom,
 }
 
-#[cfg(not(target_os = "windows"))]
 impl Participant {
     pub fn identity(&self) -> ParticipantIdentity {
         match self {
@@ -30,7 +27,6 @@ impl Participant {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl LocalParticipant {
     pub async fn unpublish_track(&self, track: &TrackSid) -> Result<()> {
         self.room
@@ -64,7 +60,6 @@ impl LocalParticipant {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl RemoteParticipant {
     pub fn track_publications(&self) -> HashMap<TrackSid, RemoteTrackPublication> {
         if let Some(room) = self.room.upgrade() {

crates/livekit_client/src/test/publication.rs

@@ -8,20 +8,17 @@ pub enum TrackPublication {
 
 #[derive(Clone, Debug)]
 pub struct LocalTrackPublication {
-    #[cfg(not(target_os = "windows"))]
     pub(crate) sid: TrackSid,
     pub(crate) room: WeakRoom,
 }
 
 #[derive(Clone, Debug)]
 pub struct RemoteTrackPublication {
-    #[cfg(not(target_os = "windows"))]
     pub(crate) sid: TrackSid,
     pub(crate) room: WeakRoom,
     pub(crate) track: RemoteTrack,
 }
 
-#[cfg(not(target_os = "windows"))]
 impl TrackPublication {
     pub fn sid(&self) -> TrackSid {
         match self {
@@ -38,7 +35,6 @@ impl TrackPublication {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl LocalTrackPublication {
     pub fn sid(&self) -> TrackSid {
         self.sid.clone()
@@ -71,7 +67,6 @@ impl LocalTrackPublication {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl RemoteTrackPublication {
     pub fn sid(&self) -> TrackSid {
         self.sid.clone()

crates/livekit_client/src/test/track.rs

@@ -1,8 +1,6 @@
 use super::*;
-#[cfg(not(windows))]
 use webrtc::{audio_source::RtcAudioSource, video_source::RtcVideoSource};
 
-#[cfg(not(windows))]
 pub use livekit::track::{TrackKind, TrackSource};
 
 #[derive(Clone, Debug)]
@@ -25,14 +23,12 @@ pub struct LocalAudioTrack {}
 
 #[derive(Clone, Debug)]
 pub struct RemoteVideoTrack {
-    #[cfg(not(target_os = "windows"))]
     pub(super) server_track: Arc<TestServerVideoTrack>,
     pub(super) _room: WeakRoom,
 }
 
 #[derive(Clone, Debug)]
 pub struct RemoteAudioTrack {
-    #[cfg(not(target_os = "windows"))]
     pub(super) server_track: Arc<TestServerAudioTrack>,
     pub(super) room: WeakRoom,
 }
@@ -43,17 +39,14 @@ pub enum RtcTrack {
 }
 
 pub struct RtcAudioTrack {
-    #[cfg(not(target_os = "windows"))]
     pub(super) server_track: Arc<TestServerAudioTrack>,
     pub(super) room: WeakRoom,
 }
 
 pub struct RtcVideoTrack {
-    #[cfg(not(target_os = "windows"))]
     pub(super) _server_track: Arc<TestServerVideoTrack>,
 }
 
-#[cfg(not(target_os = "windows"))]
 impl RemoteTrack {
     pub fn sid(&self) -> TrackSid {
         match self {
@@ -84,21 +77,18 @@ impl RemoteTrack {
     }
 }
 
-#[cfg(not(windows))]
 impl LocalVideoTrack {
     pub fn create_video_track(_name: &str, _source: RtcVideoSource) -> Self {
         Self {}
     }
 }
 
-#[cfg(not(windows))]
 impl LocalAudioTrack {
     pub fn create_audio_track(_name: &str, _source: RtcAudioSource) -> Self {
         Self {}
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl RemoteAudioTrack {
     pub fn sid(&self) -> TrackSid {
         self.server_track.sid.clone()
@@ -134,7 +124,6 @@ impl RemoteAudioTrack {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl RemoteVideoTrack {
     pub fn sid(&self) -> TrackSid {
         self.server_track.sid.clone()
@@ -151,7 +140,6 @@ impl RemoteVideoTrack {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl RtcTrack {
     pub fn enabled(&self) -> bool {
         match self {
@@ -168,7 +156,6 @@ impl RtcTrack {
     }
 }
 
-#[cfg(not(target_os = "windows"))]
 impl RtcAudioTrack {
     pub fn set_enabled(&self, enabled: bool) {
         if let Some(room) = self.room.upgrade() {