Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve logging when avatar request fails

Browse source 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
This commit is contained in:
Max Brunsfeld 2021-10-04 15:47:18 -07:00
parent 75cf2488db
commit 748598e419
2 changed files with 35 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/zed/src/user.rs
View file

@ -209,7 +209,7 @@ impl User {
User {
id: message.id,
github_login: message.github_login,
avatar: fetch_avatar(http, &message.avatar_url).log_err().await,
avatar: fetch_avatar(http, &message.avatar_url).warn_on_err().await,
}
}
}
@ -257,6 +257,9 @@ async fn fetch_avatar(http: &dyn HttpClient, url: &str) -> Result<Arc<ImageData>
.send(request)
.await
.map_err(|e| anyhow!("failed to send user avatar request: {}", e))?;
if !response.status().is_success() {
return Err(anyhow!("avatar request failed {:?}", response.status()));
}
let bytes = response
.body_bytes()
.await