Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ui: Don't add an on_click handler for disabled ListItems (#23569)

Browse source 
This PR updates the `ListItem` component to not register an `on_click`
handler for `ListItem`s that are disabled.

When working on #23350 I noticed that even when the context menu entry
was disabled you could still click on the entry to fire the action.

Release Notes:

- Fixed some instances of disabled list items still registering clicks.
This commit is contained in:
Marshall Bowers 2025-01-23 14:58:07 -05:00 • committed by GitHub
parent 5ef5b75099
commit 76bf4686ef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/ui/src/components/list/list_item.rs
View file

@ -245,9 +245,10 @@ impl RenderOnce for ListItem {
}) })
}) })
}) })
.when_some(self.on_click, |this, on_click| { .when_some(
this.cursor_pointer().on_click(on_click) self.on_click.filter(|_| !self.disabled),
}) |this, on_click| this.cursor_pointer().on_click(on_click),
)
.when(self.outlined, |this| { .when(self.outlined, |this| {
this.border_1() this.border_1()
.border_color(cx.theme().colors().border) .border_color(cx.theme().colors().border)