Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

task: Always use untruncated label if it is short (#23611)

Browse source 
Also changed rust tasks to be less mouthful.

Release Notes:

- Shortened Rust task labels.
- Task modal will now use full task label when it does not require
truncation.
This commit is contained in:
Piotr Osiewicz 2025-01-24 17:46:48 +01:00 • committed by GitHub
parent 7c2b17540b
commit 77e9d01b39
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 31 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

27
crates/task/src/task_template.rs
View file

@ -154,12 +154,26 @@ impl TaskTemplate {
None => None,
}
.or(cx.cwd.clone());
let human_readable_label = substitute_all_template_variables_in_str(
let full_label = substitute_all_template_variables_in_str(
&self.label,
&truncated_variables,
&task_variables,
&variable_names,
&mut substituted_variables,
)?
)?;
// Arbitrarily picked threshold below which we don't truncate any variables.
const TRUNCATION_THRESHOLD: usize = 64;
let human_readable_label = if full_label.len() > TRUNCATION_THRESHOLD {
substitute_all_template_variables_in_str(
&self.label,
&truncated_variables,
&variable_names,
&mut substituted_variables,
)?
} else {
full_label.clone()
}
.lines()
.fold(String::new(), |mut string, line| {
if string.is_empty() {
@ -170,12 +184,7 @@ impl TaskTemplate {
}
string
});
let full_label = substitute_all_template_variables_in_str(
&self.label,
&task_variables,
&variable_names,
&mut substituted_variables,
)?;
let command = substitute_all_template_variables_in_str(
&self.command,
&task_variables,