Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

assistant: Replace an expect with a precondition check (#12292)

Browse source 
This PR replaces an `expect` with a precondition check to avoid a panic
if the `LspAdapterDelegate` isn't set when invoking a slash command.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-05-25 15:59:40 -04:00 • committed by GitHub
parent 8450d63ed6
commit 78aaa29d5b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/assistant/src/assistant_panel.rs
View file

@ -1858,20 +1858,18 @@ impl Conversation {
let name = &line[call.name];
if let Some(call) = unchanged_call {
new_calls.push(call);
} else if let Some(command) = this.slash_command_registry.command(name) {
} else if let Some((command, lsp_adapter_delegate)) = this
.slash_command_registry
.command(name)
.zip(this.lsp_adapter_delegate.clone())
{
changed = true;
let name = name.to_string();
let source_range =
buffer.anchor_after(offset)..buffer.anchor_before(line_end_offset);
let argument = call.argument.map(|range| &line[range]);
let invocation = command.run(
argument,
this.lsp_adapter_delegate
.clone()
.expect("no LspAdapterDelegate present when invoking command"),
cx,
);
let invocation = command.run(argument, lsp_adapter_delegate, cx);
new_calls.push(SlashCommandCall {
name,