Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ui: Use PopoverMenu::new for constructing PopoverMenus (#13178)

Browse source 
This PR replaces the `popover_menu` function for constructing
`PopoverMenu`s with a `PopoverMenu::new` associated function.

This brings `PopoverMenu` in line with our other UI components.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-06-17 18:14:37 -04:00 • committed by GitHub
parent 59104a08fd
commit 78e0f71a28
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 53 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/inline_completion_button/src/inline_completion_button.rs
View file

@ -21,7 +21,7 @@ use workspace::{
item::ItemHandle,
notifications::NotificationId,
ui::{
popover_menu, ButtonCommon, Clickable, ContextMenu, IconButton, IconName, IconSize, Tooltip,
ButtonCommon, Clickable, ContextMenu, IconButton, IconName, IconSize, PopoverMenu, Tooltip,
},
StatusItemView, Toast, Workspace,
};
@ -112,7 +112,7 @@ impl Render for InlineCompletionButton {
let this = cx.view().clone();
div().child(
popover_menu("copilot")
PopoverMenu::new("copilot")
.menu(move |cx| {
Some(match status {
Status::Authorized => {
@ -161,7 +161,7 @@ impl Render for InlineCompletionButton {
let this = cx.view().clone();
return div().child(
popover_menu("supermaven")
PopoverMenu::new("supermaven")
.menu(move |cx| match &status {
SupermavenButtonStatus::NeedsActivation(activate_url) => {
Some(ContextMenu::build(cx, |menu, _| {