Suggest unsaved buffer content text as the default filename (#35707)
Closes #24672 This PR complements a feature added earlier by @JosephTLyons (in https://github.com/zed-industries/zed/pull/32353) where the text is considered as the tab title in a new buffer. It piggybacks off that change and sets the title as the suggested filename in the save dialog (completely mirroring the same functionality in VSCode):  Release Notes: - Text entered in a new untitled buffer is considered as the default filename when saving
This commit is contained in:
parent
485802b9e5
commit
7993ee9c07
10 changed files with 75 additions and 18 deletions
|
@ -270,6 +270,12 @@ pub trait Item: Focusable + EventEmitter<Self::Event> + Render + Sized {
|
|||
/// Returns the textual contents of the tab.
|
||||
fn tab_content_text(&self, _detail: usize, _cx: &App) -> SharedString;
|
||||
|
||||
/// Returns the suggested filename for saving this item.
|
||||
/// By default, returns the tab content text.
|
||||
fn suggested_filename(&self, cx: &App) -> SharedString {
|
||||
self.tab_content_text(0, cx)
|
||||
}
|
||||
|
||||
fn tab_icon(&self, _window: &Window, _cx: &App) -> Option<Icon> {
|
||||
None
|
||||
}
|
||||
|
@ -497,6 +503,7 @@ pub trait ItemHandle: 'static + Send {
|
|||
) -> gpui::Subscription;
|
||||
fn tab_content(&self, params: TabContentParams, window: &Window, cx: &App) -> AnyElement;
|
||||
fn tab_content_text(&self, detail: usize, cx: &App) -> SharedString;
|
||||
fn suggested_filename(&self, cx: &App) -> SharedString;
|
||||
fn tab_icon(&self, window: &Window, cx: &App) -> Option<Icon>;
|
||||
fn tab_tooltip_text(&self, cx: &App) -> Option<SharedString>;
|
||||
fn tab_tooltip_content(&self, cx: &App) -> Option<TabTooltipContent>;
|
||||
|
@ -631,6 +638,10 @@ impl<T: Item> ItemHandle for Entity<T> {
|
|||
self.read(cx).tab_content_text(detail, cx)
|
||||
}
|
||||
|
||||
fn suggested_filename(&self, cx: &App) -> SharedString {
|
||||
self.read(cx).suggested_filename(cx)
|
||||
}
|
||||
|
||||
fn tab_icon(&self, window: &Window, cx: &App) -> Option<Icon> {
|
||||
self.read(cx).tab_icon(window, cx)
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue