Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -66,7 +66,7 @@ impl ChannelView {
|
|||
channel_id,
|
||||
link_position,
|
||||
pane.clone(),
|
||||
workspace.clone(),
|
||||
workspace,
|
||||
window,
|
||||
cx,
|
||||
);
|
||||
|
|
|
@ -1038,7 +1038,7 @@ impl Render for ChatPanel {
|
|||
.cloned();
|
||||
|
||||
el.when_some(reply_message, |el, reply_message| {
|
||||
let user_being_replied_to = reply_message.sender.clone();
|
||||
let user_being_replied_to = reply_message.sender;
|
||||
|
||||
el.child(
|
||||
h_flex()
|
||||
|
|
|
@ -2507,7 +2507,7 @@ impl CollabPanel {
|
|||
|
||||
let button = match section {
|
||||
Section::ActiveCall => channel_link.map(|channel_link| {
|
||||
let channel_link_copy = channel_link.clone();
|
||||
let channel_link_copy = channel_link;
|
||||
IconButton::new("channel-link", IconName::Copy)
|
||||
.icon_size(IconSize::Small)
|
||||
.size(ButtonSize::None)
|
||||
|
@ -2691,7 +2691,7 @@ impl CollabPanel {
|
|||
h_flex()
|
||||
.w_full()
|
||||
.justify_between()
|
||||
.child(Label::new(github_login.clone()))
|
||||
.child(Label::new(github_login))
|
||||
.child(h_flex().children(controls)),
|
||||
)
|
||||
.start_slot(Avatar::new(user.avatar_uri.clone()))
|
||||
|
@ -3125,7 +3125,7 @@ impl Panel for CollabPanel {
|
|||
|
||||
impl Focusable for CollabPanel {
|
||||
fn focus_handle(&self, cx: &App) -> gpui::FocusHandle {
|
||||
self.filter_editor.focus_handle(cx).clone()
|
||||
self.filter_editor.focus_handle(cx)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -289,7 +289,7 @@ impl NotificationPanel {
|
|||
.gap_1()
|
||||
.size_full()
|
||||
.overflow_hidden()
|
||||
.child(Label::new(text.clone()))
|
||||
.child(Label::new(text))
|
||||
.child(
|
||||
h_flex()
|
||||
.child(
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue