Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -81,10 +81,7 @@ pub fn init(
|
|||
};
|
||||
copilot_chat::init(fs.clone(), http.clone(), configuration, cx);
|
||||
|
||||
let copilot = cx.new({
|
||||
let node_runtime = node_runtime.clone();
|
||||
move |cx| Copilot::start(new_server_id, fs, node_runtime, cx)
|
||||
});
|
||||
let copilot = cx.new(move |cx| Copilot::start(new_server_id, fs, node_runtime, cx));
|
||||
Copilot::set_global(copilot.clone(), cx);
|
||||
cx.observe(&copilot, |copilot, cx| {
|
||||
copilot.update(cx, |copilot, cx| copilot.update_action_visibilities(cx));
|
||||
|
|
|
@ -1083,7 +1083,7 @@ mod tests {
|
|||
let replace_range_marker: TextRangeMarker = ('<', '>').into();
|
||||
let (_, mut marked_ranges) = marked_text_ranges_by(
|
||||
marked_string,
|
||||
vec![complete_from_marker.clone(), replace_range_marker.clone()],
|
||||
vec![complete_from_marker, replace_range_marker.clone()],
|
||||
);
|
||||
|
||||
let replace_range =
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue