Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -7209,7 +7209,7 @@ fn render_blame_entry_popover(
|
|||
) -> Option<AnyElement> {
|
||||
let renderer = cx.global::<GlobalBlameRenderer>().0.clone();
|
||||
let blame = blame.read(cx);
|
||||
let repository = blame.repository(cx)?.clone();
|
||||
let repository = blame.repository(cx)?;
|
||||
renderer.render_blame_entry_popover(
|
||||
blame_entry,
|
||||
scroll_handle,
|
||||
|
@ -9009,7 +9009,7 @@ impl Element for EditorElement {
|
|||
.as_ref()
|
||||
.map(|layout| (layout.bounds, layout.entry.clone())),
|
||||
display_hunks: display_hunks.clone(),
|
||||
diff_hunk_control_bounds: diff_hunk_control_bounds.clone(),
|
||||
diff_hunk_control_bounds,
|
||||
});
|
||||
|
||||
self.editor.update(cx, |editor, _| {
|
||||
|
@ -9894,7 +9894,7 @@ impl CursorLayout {
|
|||
.px_0p5()
|
||||
.line_height(text_size + px(2.))
|
||||
.text_color(cursor_name.color)
|
||||
.child(cursor_name.string.clone())
|
||||
.child(cursor_name.string)
|
||||
.into_any_element();
|
||||
|
||||
name_element.prepaint_as_root(name_origin, AvailableSpace::min_size(), window, cx);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue