Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -90,11 +90,8 @@ impl ExampleInstance {
|
|||
worktrees_dir: &Path,
|
||||
repetition: usize,
|
||||
) -> Self {
|
||||
let name = thread.meta().name.to_string();
|
||||
let run_directory = run_dir
|
||||
.join(&name)
|
||||
.join(repetition.to_string())
|
||||
.to_path_buf();
|
||||
let name = thread.meta().name;
|
||||
let run_directory = run_dir.join(&name).join(repetition.to_string());
|
||||
|
||||
let repo_path = repo_path_for_url(repos_dir, &thread.meta().url);
|
||||
|
||||
|
@ -772,7 +769,7 @@ pub async fn query_lsp_diagnostics(
|
|||
}
|
||||
|
||||
fn parse_assertion_result(response: &str) -> Result<RanAssertionResult> {
|
||||
let analysis = get_tag("analysis", response)?.to_string();
|
||||
let analysis = get_tag("analysis", response)?;
|
||||
let passed = match get_tag("passed", response)?.to_lowercase().as_str() {
|
||||
"true" => true,
|
||||
"false" => false,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue