Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -61,7 +61,6 @@ impl RenderOnce for FeatureUpsell {
|
|||
.icon_size(IconSize::Small)
|
||||
.icon_position(IconPosition::End)
|
||||
.on_click({
|
||||
let docs_url = docs_url.clone();
|
||||
move |_event, _window, cx| {
|
||||
telemetry::event!(
|
||||
"Documentation Viewed",
|
||||
|
|
|
@ -694,7 +694,7 @@ impl ExtensionsPage {
|
|||
cx.open_url(&repository_url);
|
||||
}
|
||||
}))
|
||||
.tooltip(Tooltip::text(repository_url.clone()))
|
||||
.tooltip(Tooltip::text(repository_url))
|
||||
})),
|
||||
)
|
||||
}
|
||||
|
@ -827,7 +827,7 @@ impl ExtensionsPage {
|
|||
cx.open_url(&repository_url);
|
||||
}
|
||||
}))
|
||||
.tooltip(Tooltip::text(repository_url.clone())),
|
||||
.tooltip(Tooltip::text(repository_url)),
|
||||
)
|
||||
.child(
|
||||
PopoverMenu::new(SharedString::from(format!(
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue